updated linter version, changed revive linter sensitivity

See merge request !428

.gitlab/ci/.code-quality-ci.yml

 variables:
     GOLANG_VERSION: "1.20.1"
 code-quality:
-    image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/golangci/golangci-lint:v1.46-alpine
+    image: golangci/golangci-lint:v1.51.2-alpine
     stage: analyze
     script:
         # writes golangci-lint output to gl-code-quality-report.json

.golangci.yml

@@ -51,10 +51,8 @@ linters:
         - typecheck
         - revive
         - whitespace
-        - deadcode
         - errcheck
         - ineffassign
-        - varcheck
         - bidichk
         - durationcheck
         - errorlint
@@ -78,3 +76,6 @@ linters-settings:
         # Such cases aren't reported by default.
         # Default: false
         check-type-assertions: true
+    revive:
+        severity: warning
+        confidence: 0.8

Makefile

@@ -28,7 +28,7 @@ install-tools:
 	@echo Install development tooling
 	mkdir -p $(GOSDN_PRG)
 	export GOBIN=$(GOSDN_PRG) && go install gotest.tools/gotestsum@v1.8.1 &&\
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 &&\
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 &&\
 	go install github.com/vektra/mockery/v2@v2.14.0 &&\
 	go install github.com/openconfig/ygot/generator@v0.20.2 &&\
 	go install github.com/andresterba/go-ygot-generator-generator@v0.0.2

controller/Makefile

@@ -15,7 +15,7 @@ install-tools:
 	@echo Install development tooling
 	mkdir -p $(GOSDN_PRG)
 	go install gotest.tools/gotestsum@v1.7.0
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2
 	go install github.com/vektra/mockery/v2@v2.14.0
 	@echo Finished installing development tooling
 

csbi/build/ci/.code-quality-ci.yml

 code-quality:
-  image: golangci/golangci-lint:v1.46-alpine
+  image: golangci/golangci-lint:v1.51.2-alpine
   stage: test
   rules:
     - if: $CI_PIPELINE_SOURCE == "merge_request_event"