From 8616f03e3e9ec724a51d937756dd717264bc139b Mon Sep 17 00:00:00 2001
From: Katharina Renk <katharina.renk@stud.h-da.de>
Date: Tue, 28 Feb 2023 08:22:48 +0000
Subject: [PATCH] updated linter version, changed revive linter sensitivity
See merge request danet/gosdn!428
---
.gitlab/ci/.code-quality-ci.yml | 2 +-
.golangci.yml | 5 +++--
Makefile | 2 +-
controller/Makefile | 2 +-
csbi/build/ci/.code-quality-ci.yml | 2 +-
5 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/.gitlab/ci/.code-quality-ci.yml b/.gitlab/ci/.code-quality-ci.yml
index 85f49c09e..3b8dd10fe 100644
--- a/.gitlab/ci/.code-quality-ci.yml
+++ b/.gitlab/ci/.code-quality-ci.yml
@@ -1,7 +1,7 @@
variables:
GOLANG_VERSION: "1.20.1"
code-quality:
- image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/golangci/golangci-lint:v1.46-alpine
+ image: golangci/golangci-lint:v1.51.2-alpine
stage: analyze
script:
# writes golangci-lint output to gl-code-quality-report.json
diff --git a/.golangci.yml b/.golangci.yml
index 652493ad3..6b9b26064 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -51,10 +51,8 @@ linters:
- typecheck
- revive
- whitespace
- - deadcode
- errcheck
- ineffassign
- - varcheck
- bidichk
- durationcheck
- errorlint
@@ -78,3 +76,6 @@ linters-settings:
# Such cases aren't reported by default.
# Default: false
check-type-assertions: true
+ revive:
+ severity: warning
+ confidence: 0.8
diff --git a/Makefile b/Makefile
index b9899db34..6041223cb 100644
--- a/Makefile
+++ b/Makefile
@@ -28,7 +28,7 @@ install-tools:
@echo Install development tooling
mkdir -p $(GOSDN_PRG)
export GOBIN=$(GOSDN_PRG) && go install gotest.tools/gotestsum@v1.8.1 &&\
- go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 &&\
+ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 &&\
go install github.com/vektra/mockery/v2@v2.14.0 &&\
go install github.com/openconfig/ygot/generator@v0.20.2 &&\
go install github.com/andresterba/go-ygot-generator-generator@v0.0.2
diff --git a/controller/Makefile b/controller/Makefile
index 7eb9ab699..6e9b91496 100644
--- a/controller/Makefile
+++ b/controller/Makefile
@@ -15,7 +15,7 @@ install-tools:
@echo Install development tooling
mkdir -p $(GOSDN_PRG)
go install gotest.tools/gotestsum@v1.7.0
- go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46
+ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2
go install github.com/vektra/mockery/v2@v2.14.0
@echo Finished installing development tooling
diff --git a/csbi/build/ci/.code-quality-ci.yml b/csbi/build/ci/.code-quality-ci.yml
index f0d1f75fb..df1514f79 100644
--- a/csbi/build/ci/.code-quality-ci.yml
+++ b/csbi/build/ci/.code-quality-ci.yml
@@ -1,5 +1,5 @@
code-quality:
- image: golangci/golangci-lint:v1.46-alpine
+ image: golangci/golangci-lint:v1.51.2-alpine
stage: test
rules:
- if: $CI_PIPELINE_SOURCE == "merge_request_event"
--
GitLab