diff --git a/.gitlab/ci/.code-quality-ci.yml b/.gitlab/ci/.code-quality-ci.yml index 85f49c09e013908795f7e0c75d78812a055d6861..3b8dd10fe9af5e5dd446ebc322c68f86f448a256 100644 --- a/.gitlab/ci/.code-quality-ci.yml +++ b/.gitlab/ci/.code-quality-ci.yml @@ -1,7 +1,7 @@ variables: GOLANG_VERSION: "1.20.1" code-quality: - image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/golangci/golangci-lint:v1.46-alpine + image: golangci/golangci-lint:v1.51.2-alpine stage: analyze script: # writes golangci-lint output to gl-code-quality-report.json diff --git a/.golangci.yml b/.golangci.yml index 652493ad3cf2ce309c2ab5ffbeeb7bbedd01388a..6b9b260642f7024dac9c49f93ad26af496ccb780 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -51,10 +51,8 @@ linters: - typecheck - revive - whitespace - - deadcode - errcheck - ineffassign - - varcheck - bidichk - durationcheck - errorlint @@ -78,3 +76,6 @@ linters-settings: # Such cases aren't reported by default. # Default: false check-type-assertions: true + revive: + severity: warning + confidence: 0.8 diff --git a/Makefile b/Makefile index b9899db34f3431461fe55d7d9da9f52bbc5dc935..6041223cb4109177f65989e13b6187461a1f4cd8 100644 --- a/Makefile +++ b/Makefile @@ -28,7 +28,7 @@ install-tools: @echo Install development tooling mkdir -p $(GOSDN_PRG) export GOBIN=$(GOSDN_PRG) && go install gotest.tools/gotestsum@v1.8.1 &&\ - go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 &&\ + go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 &&\ go install github.com/vektra/mockery/v2@v2.14.0 &&\ go install github.com/openconfig/ygot/generator@v0.20.2 &&\ go install github.com/andresterba/go-ygot-generator-generator@v0.0.2 diff --git a/controller/Makefile b/controller/Makefile index 7eb9ab69948d619a524ae62cc8f39773b6521fa8..6e9b914963fb9d22d3ae6844a7758d877ba36d70 100644 --- a/controller/Makefile +++ b/controller/Makefile @@ -15,7 +15,7 @@ install-tools: @echo Install development tooling mkdir -p $(GOSDN_PRG) go install gotest.tools/gotestsum@v1.7.0 - go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 + go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 go install github.com/vektra/mockery/v2@v2.14.0 @echo Finished installing development tooling diff --git a/csbi/build/ci/.code-quality-ci.yml b/csbi/build/ci/.code-quality-ci.yml index f0d1f75fbf1990c015944c771976a5de4f466dc5..df1514f7955f51f7445380f4c08557f0b8f4f55a 100644 --- a/csbi/build/ci/.code-quality-ci.yml +++ b/csbi/build/ci/.code-quality-ci.yml @@ -1,5 +1,5 @@ code-quality: - image: golangci/golangci-lint:v1.46-alpine + image: golangci/golangci-lint:v1.51.2-alpine stage: test rules: - if: $CI_PIPELINE_SOURCE == "merge_request_event"