Skip to content

Resolve "AddLink crashes goSDN when Link without correct port config is send."

This MR extends Links within their .proto definition. Additionally the topology store has been slightly adjusted so that the integration-tests for topology are runnable again. .proto files are generated with protoc-gen-go v1.32.0.

Description

Links have now an additional required field: Configuration.

The topology store is now working with the binary representation of a uuid as identifier, since we do not work with a LoadedLink struct as we normally do (e.g., LoadedUser,LoadedRole, ...). This is something that should be addressed but since there is also an open discussion about the future implementation of the topology (#346), this should be addressed after a decision has been made there.

Related Issue

Related to #345

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Malte Bauch

Merge request reports