Refactor mongo store handling
All threads resolved!
All threads resolved!
Description
This MR removes the connection handling from the database store implementions.
Instead we connect a single time in the controller.go
to the mongo database and reuse that connection in all stores.
It also adds context handling to the store layer. Currently the context is created in the service layer, but this should be moved to northbound to use the same context through the whole call stack. (will be done in another MR soon)
Motivation and Context
This change removes code duplication in all mongo store implementations.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I have read the CONTRIBUTING document. -
I have added tests to cover my changes. -
All new and existing tests passed.
Edited by André Sterba
Merge request reports
Activity
added 4 commits
-
b41dcfd9...a822bbfa - 3 commits from branch
master
- e6b553ae - Merge branch 'master' into refactor-mongo-store-handling
-
b41dcfd9...a822bbfa - 3 commits from branch
- Resolved by Fabian Seidl
- Resolved by Fabian Seidl
- Resolved by Fabian Seidl
- Resolved by Fabian Seidl
- Resolved by Fabian Seidl
- Resolved by Fabian Seidl
assigned to @hda1
added 4 commits
-
87c1866c...034136a5 - 3 commits from branch
master
- b6e705a7 - Merge branch 'master' into refactor-mongo-store-handling
-
87c1866c...034136a5 - 3 commits from branch
added 22 commits
-
b6e705a7...0bcfb831 - 12 commits from branch
master
- bbb951b1 - Refactor db connection to central function
- fdf778b3 - Fix store name
- e170ad2e - Fix lint errors
- 5cd1c619 - Working on tests
- f7ab0258 - Fix tests
- f566d4d9 - Fix tests
- 9d5d5a39 - Apply feedback 1
- ea4cafc7 - Apply feedback 2
- faebb079 - Apply feedback 3
- 2b417418 - Apply feedback 4
Toggle commit list-
b6e705a7...0bcfb831 - 12 commits from branch
enabled an automatic merge when the pipeline for 2b417418 succeeds
mentioned in commit db489f19
Please register or sign in to reply