Skip to content
Snippets Groups Projects

Add test for role api inputs

Merged André Sterba requested to merge validation-tests into master

Description

This is an attempt to make the api more testable by exposing the earlier added validation errors as proper types instead of plain strings.

Related Issue

#232

Motivation and Context

We should be able to provide proper error messages, when an user input is not as intended and fails validation. This was already in place with the implementation of #232, but only as a string not as typed outputs. Therefore the usability in tests and by application was rather non existend.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by André Sterba

Merge request reports

Pipeline #164184 passed

Pipeline passed for 47cb2d63 on validation-tests

Test coverage 30.40% (0.30%) from 1 job
Approved by

Merged by Neil-Jocelyn ScharkNeil-Jocelyn Schark 1 year ago (Oct 18, 2023 10:01am UTC)

Merge details

  • Changes merged into master with fe9496c6 (commits were squashed).
  • Deleted the source branch.

Pipeline #164206 passed

Pipeline passed for fe9496c6 on master

Test coverage 30.40% (0.30%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading