Skip to content

Resolve "After failing to add a network element to the storage, it is not possible to redo this because of an issue with a file lock in the plugin regitry"

Malte Bauch requested to merge 279-after-failing-to-add-a-network-element-to-the-storage-it-is-not-possible-to-redo-this-because into master

Description

This change fixes the text file is busy error if multiple network elements are registered using the same plugin. With this change it is ensured that the RequestPlugin method within the controller checks if the requested plugin has already been requested before and is therefore already present. If this is the case the plugin is reused and not downloaded again. Plugin has been extended with the path to the executable that is used.

Related Issue

#279 (closed)

Motivation and Context

If multiple network elements are registered using the same plugin requested from the plugin registry the user was presented with the text file is busy error. It should be possible to create multiple devices using the same plugin.

How Has This Been Tested?

Multiple devices with the same plugin have been created and the corresponding database entries have been checked. If a plugin was already requested once it is not downloaded again.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #279 (closed)

Edited by Malte Bauch

Merge request reports