Skip to content
Snippets Groups Projects

Resolve "Error handling in event publishing via entity services could be improved"

7 files
+ 144
24
Compare changes
  • Side-by-side
  • Inline
Files
7
@@ -82,7 +82,12 @@ func (s *DeviceService) Add(deviceToAdd device.Device) error {
@@ -82,7 +82,12 @@ func (s *DeviceService) Add(deviceToAdd device.Device) error {
pubEvent := event.NewAddEvent(deviceToAdd.ID())
pubEvent := event.NewAddEvent(deviceToAdd.ID())
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if retryErr := s.eventService.RetryPublish(DeviceEventTopic, pubEvent); retryErr != nil {
var retryErr error
 
go func() {
 
retryErr = s.eventService.RetryPublish(DeviceEventTopic, pubEvent)
 
}()
 
 
if retryErr != nil {
log.Error(retryErr)
log.Error(retryErr)
}
}
}
}
@@ -116,7 +121,12 @@ func (s *DeviceService) UpdateModel(deviceToUpdate device.Device, modelAsString
@@ -116,7 +121,12 @@ func (s *DeviceService) UpdateModel(deviceToUpdate device.Device, modelAsString
pubEvent := event.NewUpdateEvent(deviceToUpdate.ID())
pubEvent := event.NewUpdateEvent(deviceToUpdate.ID())
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if retryErr := s.eventService.RetryPublish(DeviceEventTopic, pubEvent); retryErr != nil {
var retryErr error
 
go func() {
 
retryErr = s.eventService.RetryPublish(DeviceEventTopic, pubEvent)
 
}()
 
 
if retryErr != nil {
log.Error(retryErr)
log.Error(retryErr)
}
}
}
}
@@ -133,7 +143,12 @@ func (s *DeviceService) Update(deviceToUpdate device.Device) error {
@@ -133,7 +143,12 @@ func (s *DeviceService) Update(deviceToUpdate device.Device) error {
pubEvent := event.NewUpdateEvent(deviceToUpdate.ID())
pubEvent := event.NewUpdateEvent(deviceToUpdate.ID())
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if retryErr := s.eventService.RetryPublish(DeviceEventTopic, pubEvent); retryErr != nil {
var retryErr error
 
go func() {
 
retryErr = s.eventService.RetryPublish(DeviceEventTopic, pubEvent)
 
}()
 
 
if retryErr != nil {
log.Error(retryErr)
log.Error(retryErr)
}
}
}
}
@@ -156,7 +171,12 @@ func (s *DeviceService) Delete(deviceToDelete device.Device) error {
@@ -156,7 +171,12 @@ func (s *DeviceService) Delete(deviceToDelete device.Device) error {
pubEvent := event.NewDeleteEvent(deviceToDelete.ID())
pubEvent := event.NewDeleteEvent(deviceToDelete.ID())
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if err := s.eventService.PublishEvent(DeviceEventTopic, pubEvent); err != nil {
if retryErr := s.eventService.RetryPublish(DeviceEventTopic, pubEvent); retryErr != nil {
var retryErr error
 
go func() {
 
retryErr = s.eventService.RetryPublish(DeviceEventTopic, pubEvent)
 
}()
 
 
if retryErr != nil {
log.Error(retryErr)
log.Error(retryErr)
}
}
}
}
Loading