Resolve "Logging in while having an expired token shows an unnecessary error"
Merged
requested to merge 234-logging-in-while-having-an-expired-token-shows-an-unnecessary-error into develop
All threads resolved!
Description
See #234 (closed)
Edited by Ghost User
Merge request reports
Activity
- A deleted user
added componentcli statusavailable typeimprovement labels
added 1 commit
- 34069a3b - added mechanism to prevent wrongly sending an error when logging in with expired token
requested review from @istaester and @ext10578
- A deleted user
added statusreview label and removed statusavailable label
added 1 commit
- f563aa57 - updated naming, check for login didn'T make any sense
- Resolved
If I understand the issue correctly we always call logout in the cli, before a login? I don't see why we want to add a bool flag to a controller internal method, simply because the cli has this weird behaviour
But maybe I miss something here?
Edited by Ghost User
added 6 commits
-
f563aa57...8ed37da0 - 5 commits from branch
develop
- 2195ad1c - Merge branch 'develop' into 234-logging-in-while-having-an-expired-token-shows-an-unnecessary-error
-
f563aa57...8ed37da0 - 5 commits from branch
added 5 commits
-
2195ad1c...cea0eacf - 4 commits from branch
develop
- 229ff08e - Merge branch 'develop' into 234-logging-in-while-having-an-expired-token-shows-an-unnecessary-error
-
2195ad1c...cea0eacf - 4 commits from branch
added 1 commit
- 278ecb75 - reverted earlier changes, added solution ignoring the error on cli side
added 5 commits
-
e3dc440b - 1 commit from branch
develop
- 784b52eb - added mechanism to prevent wrongly sending an error when logging in with expired token
- a6a177ae - linting
- 30b99599 - updated naming, check for login didn'T make any sense
- 96acc236 - reverted earlier changes, added solution ignoring the error on cli side
Toggle commit list-
e3dc440b - 1 commit from branch
- A deleted user
merged
mentioned in commit 9212f3ff
Please register or sign in to reply