Skip to content
Snippets Groups Projects

Resolve "Inconsistency and wrong definitions of requests/responses in proto files"

Merged Resolve "Inconsistency and wrong definitions of requests/responses in proto files"
203-inconsistency-and-wrong-definitions-of-requests-responses-in-proto-files into develop
All threads resolved!
Merged Ghost User requested to merge 203-inconsistency-and-wrong-definitions-of-requests-responses-in-proto-files into develop
All threads resolved!

Description

Proto definitions have been updated to be in line with semantics e.g. GetPnd returns only one Pnd instead of one or more. Changing proto files did require some minor changes in the way of preparing ONDs and SBIs for the response. Checked the CLI manually to see if it still works and if the presentation of returned objects looks okay.

Related Issue

#203 (closed).

Merge request reports

Pipeline #100722 passed

Stage: build
Stage: test
Stage: analyze
Stage: integration-test

Pipeline passed for b5cef15e on 203-inconsistency-and-wrong-definitions-of-requests-responses-in-proto-files

Test coverage 33.30% (-0.30%) from 1 job
Approved by
Malte Bauch

Merged by avatar (May 31, 2025 10:07am UTC)

Merge details

  • Changes merged into develop with 1319d514 (commits were squashed).
  • Deleted the source branch.

Pipeline #100723 passed

Stage: build
Stage: test
Stage: analyze
Stage: integration-test
Stage: .post

Pipeline passed for 1319d514 on develop

Test coverage 33.30% (-0.30%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Malte Bauch
  • Malte Bauch
  • Ghost User resolved all threads

    resolved all threads

  • Ghost User resolved all threads

    resolved all threads

  • Ghost User resolved all threads

    resolved all threads

  • Ghost User added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    • b5cef15e - updated generated proto files after appllying suggestions

    Compare with previous version

  • Malte Bauch approved this merge request

    approved this merge request

  • A deleted user merged

    merged

  • Ghost User mentioned in commit 1319d514

    mentioned in commit 1319d514

    • Please register or sign in to reply