WIP: Develop

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

controller/nucleus/principalNetworkDomain.go

@@ -39,6 +39,10 @@ import (
 	"github.com/spf13/viper"
 )
 
+// NOTE: Until we've added database support for changes, we will hold
+// changeStores in memory for now.
+var changeStoreMap = make(map[uuid.UUID]*store.ChangeStore)
+
 // NewPND creates a Principle Network Domain
 func NewPND(
 	name string,
@@ -49,12 +53,18 @@ func NewPND(
 ) (networkdomain.NetworkDomain, error) {
 	sbiStore := NewSbiStore(id)
 
+	changeStore, ok := changeStoreMap[id]
+	if !ok {
+		changeStore = store.NewChangeStore()
+		changeStoreMap[id] = changeStore
+	}
+
 	pnd := &pndImplementation{
 		Name:        name,
 		Description: description,
 		sbic:        sbiStore,
 		devices:     NewDeviceStore(id, sbiStore),
-		changes:     store.NewChangeStore(),
+		changes:     changeStore,
 		Id:          id,
 
 		csbiClient: c,
@@ -399,10 +409,12 @@ func (pnd *pndImplementation) RequestAll(path string) error {
 // ChangeOND creates a change from the provided Operation, path and value.
 // The Change is Pending and times out after the specified timeout period
 func (pnd *pndImplementation) ChangeOND(duid uuid.UUID, operation ppb.ApiOperation, path string, value ...string) (uuid.UUID, error) {
-	d, err := pnd.devices.Get((store.Query{
-		ID:   duid,
-		Name: "",
-	}))
+	d, err := pnd.devices.Get(store.Query{
+		ID: duid,
+	})
+	if err != nil {
+		return uuid.Nil, err
+	}
 	cpy, err := ygot.DeepCopy(d.GetModel())
 	ygot.BuildEmptyTree(cpy)
 	if err != nil {