Stfaseid http refactor

Description

Draft for new API. Needs extensive manual testing. Only merge if changes in https://code.fbi.h-da.de/danet/api/-/tree/10-refactor-current-proto-definitions-stfahelm and upcoming changes to CLI are approved.

Related Issue

#141 (closed)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

northbound/server/pnd_test.go

 package server
 
 import (
+	"context"
 	"os"
+	"reflect"
 	"testing"
 	"time"
 
+	pb "code.fbi.h-da.de/danet/api/go/gosdn/core"
 	ppb "code.fbi.h-da.de/danet/api/go/gosdn/pnd"
 	spb "code.fbi.h-da.de/danet/api/go/gosdn/southbound"
 	"code.fbi.h-da.de/danet/api/go/gosdn/transport"
@@ -171,59 +174,52 @@ func TestMain(m *testing.M) {
 func Test_pnd_Get(t *testing.T) {
 	removeExistingStores()
 
-	// type args struct {
-	// 	ctx     context.Context
-	// 	request *ppb.GetRequest
-	// }
-	// tests := []struct {
-	// 	name    string
-	// 	args    args
-	// 	want    []string
-	// 	wantErr bool
-	// }{
-	// 	{
-	// 		name: "get pnd",
-	// 		args: args{
-	// 			ctx: context.Background(),
-	// 			request: &ppb.GetRequest{
-	// 				Request: &ppb.GetRequest_Pnd{
-	// 					Pnd: &ppb.GetPnd{},
-	// 				},
-	// 				Pid: pndID,
-	// 			},
-	// 		},
-	// 		want: []string{
-	// 			pndID,
-	// 			ondID,
-	// 			sbiID,
-	// 			// pendingChangeID,
-	// 			// committedChangeID,
-	// 		},
-	// 	},
-	// }
-	// for _, tt := range tests {
-	// 	t.Run(tt.name, func(t *testing.T) {
-	// 		p := pndServer{
-	// 			UnimplementedPndServiceServer: ppb.UnimplementedPndServiceServer{},
-	// 		}
-	// 		resp, err := p.Get(tt.args.ctx, tt.args.request)
-	// 		if (err != nil) != tt.wantErr {
-	// 			t.Errorf("Get() error = %v, wantErr %v", err, tt.wantErr)
-	// 			return
-	// 		}
+	type args struct {
+		ctx     context.Context
+		request *pb.GetPndRequest
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    pb.GetPndResponse
+		wantErr bool
+	}{
+		{
+			name: "get pnd",
+			args: args{
+				ctx: context.Background(),
+				request: &pb.GetPndRequest{
+					Pid: []string{
+						pndID},
+				},
+			},
+			want: pb.GetPndResponse{
+				Pnd: []*ppb.PrincipalNetworkDomain{
+					{Id: pndID,
+						Name:        "test",
+						Description: "test"},
+				},
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			p := core{
+				UnimplementedCoreServiceServer: pb.UnimplementedCoreServiceServer{},
+			}
+			resp, err := p.GetPnd(tt.args.ctx, tt.args.request)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("Get() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
 
-	// 		got := []string{
-	// 			resp.Pnd.Id,
-	// 			resp.Pnd.Ond[0].Id,
-	// 			resp.Pnd.Sbi[0].Id,
-	// 			// resp.Pnd.Change[0].Id,
-	// 			// resp.Pnd.Change[1].Id,
-	// 		}
-	// 		if !reflect.DeepEqual(got, tt.want) {
-	// 			t.Errorf("Get() got = %v, want %v", got, tt.want)
-	// 		}
-	// 	})
-	// }
+			got := resp.GetPnd()
+
+			if !reflect.DeepEqual(got, tt.want.Pnd) {
+				t.Errorf("Get() got = %v, want %v", got, tt.want.Pnd)
+			}
+		})
+	}
 }
 
 func Test_pnd_Set(t *testing.T) {