Draft: Resolve "Stores should not have to implement the Add() method"
Compare changes
- Malte Bauch authored
Comparing a struct that contains a function value will only return true if they are nil (see [1]). This is problematic for this testcase since it will always return false. Equal() of the go-comp package can ignore unexported fields and claims to be a safer solution than reflect.DeepEqual in general [2]. As long as we assume that our tests for the storages are correct, this change should not be a problem. [1] https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/reflect/deepequal.go;l=167 [2] https://github.com/google/go-cmp/ Addresses: #160