Skip to content
Snippets Groups Projects

Add rules to pipelines

Merged Add rules to pipelines
142-add-rules-to-pipelines into develop
Merged Felix Ohms requested to merge 142-add-rules-to-pipelines into develop

Description

After a discussion in BBB, we agreed on the following:

  1. One pipeline runs at every commit, but just builds a container and runs the unit tests. So you can quickly check, if you messed something up
  2. One pipeline runs on a merge request with everything related to code. So build, test and integration tests. Licensing also runs, but only when a dependency is added or updated
  3. Nightlys get removed, as they don't test new things. Only the security and compliance pipelines are run nightly to generate the statistics.
  4. MR to develop pipeline with integration test
  • licensing only if go.mod or go.sum were edited

When exactly?

  • code quality -> currently on merge request only
  • controller test -> currently on merge request only

Related Issue

#142 (closed) Add rules to pipelines

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #142 (closed)

Edited by Felix Ohms

Merge request reports

Merge train pipeline #86584 passed

Stage: build
Merge train pipeline jobs can not be retried
Stage: test
Merge train pipeline jobs can not be retried
Stage: analyze
Merge train pipeline jobs can not be retried
Stage: apply
Merge train pipeline jobs can not be retried
Stage: integration-test
Merge train pipeline jobs can not be retried
Stage: .post
Merge train pipeline jobs can not be retried

Merge train pipeline passed for cd904b13

Test coverage 51.60% (0.00%) from 1 job
Approved by
Martin Stiemerling

Merged by Felix OhmsFelix Ohms 3 years ago (Nov 29, 2021 1:08pm UTC)

Merge details

  • Changes merged into develop with a181a3de (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #86717 passed

Stage: build
Stage: test
Stage: .post

Pipeline passed for a181a3de on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply