Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • goSDN goSDN
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • danetdanet
  • goSDNgoSDN
  • Merge requests
  • !182

Resolve "Prevent containerlab:destroy pipeline step from running if not needed"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Felix Ohms requested to merge 132-Prevent-containerlab-destroy-pipeline-step-from-running-if-not-needed into develop Jul 07, 2021
  • Overview 0
  • Commits 12
  • Pipelines 0
  • Changes 3

Description

Only run containerlab:destroy when containerlab:deploy ran, regardless of passing or failing the deployment as well as the integration tests.

Related Issue

#132 (closed)

Motivation and Context

How Has This Been Tested?

Testet for:

  • Skipping interation tests
  • Passing deployment & integration tests
  • Passing deployment; failing one or all integration tests
  • Failing deployment, therefore skipping integration tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited Jul 08, 2021 by Felix Ohms
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 132-Prevent-containerlab-destroy-pipeline-step-from-running-if-not-needed