Northbound Interface

Description

This merge request provides a new gRPC based interface and replaces the deprecated HTTP API. It brings candy and love to everyone. And the old API was dead from the beginning anyway.

This MR is for implementation aspects only. Discussion of the actual API definition with protobuf should happen here

Related Issue

#83 (closed)

Motivation and Context

gRPB based NBI was planned from the beginning.

How Has This Been Tested?

Not yet yolo

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

nucleus/device_test.go

@@ -58,7 +58,6 @@ func TestNewDevice(t *testing.T) {
 	tests := []struct {
 		name    string
 		args    args
-		want    *Device
 		wantErr bool
 	}{
 		{
@@ -80,11 +79,6 @@ func TestNewDevice(t *testing.T) {
 				},
 				name: "MyDevice",
 			},
-			want: &Device{
-				GoStruct: &openconfig.Device{},
-				SBI:      sbi,
-				UUID:     uuid.New(),
-			},
 		},
 		{
 			name: "invalid options",
@@ -97,23 +91,29 @@ func TestNewDevice(t *testing.T) {
 				},
 				name: "MyDevice",
 			},
-			want:    nil,
 			wantErr: true,
 		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got, err := NewDevice(tt.args.name, tt.args.opts, tt.args.sbi)
+			resp, err := NewDevice(tt.args.name, tt.args.opts, tt.args.sbi)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("NewDevice() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			}
-			if got != nil {
-				tt.want.Transport = got.Transport
-				tt.want.UUID = got.ID()
-			}
-			if !reflect.DeepEqual(got, tt.want) {
-				t.Errorf("NewDevice() got = %v, want %v", got, tt.want)
+			if resp != nil {
+				if reflect.TypeOf(resp.GoStruct) != reflect.TypeOf(&openconfig.Device{}) {
+					t.Error("NewDevice() returned invalid GoStruct")
+				}
+				if reflect.TypeOf(resp.Transport) != reflect.TypeOf(&Gnmi{}) {
+					t.Error("NewDevice() returned invalid transport")
+				}
+				if reflect.TypeOf(resp.SBI) != reflect.TypeOf(&OpenConfig{}) {
+					t.Error("NewDevice() returned invalid GoStruct")
+				}
+				if resp.Name != "MyDevice" {
+					t.Error("NewDevice() returned wrong name")
+				}
 			}
 		})
 	}