Skip to content
Snippets Groups Projects

Let user set a name for a device or autogenerate it

Merged Ghost User requested to merge istaester/autogenerate-device-names into develop

Description

Let user set a name for a device or autogenerate it.

Related Issue

#100 (closed)

Motivation and Context

Users should have the chance to interact with human readable device names instead of UUIDs only.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Ghost User

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
131 133 if err != nil {
132 134 log.Fatal(err)
133 135 }
136 // TODO: iid not used?
  • Ghost User
    Ghost User @ghost started a thread on commit c0222769
  • 131 136 }
    132 137
    133 138 func (pnd *pndImplementation) addDevice(device *Device) error {
    134 return pnd.devices.add(device)
    139 err := pnd.devices.add(device)
    140 if err != nil {
    141 return err
    142 }
    143
    144 pnd.deviceNameToUUIDLookup[device.Name] = device.UUID
    145
    146 return nil
    135 147 }
    136 148
    137 func (pnd *pndImplementation) getDevice(id uuid.UUID) (*Device, error) {
  • A deleted user changed milestone to %SORT

    changed milestone to %SORT

  • A deleted user added ~3086 sort labels

    added ~3086 sort labels

  • A deleted user added componentcli label and removed ~3086 label

    added componentcli label and removed ~3086 label

  • Ghost User added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User added 10 commits

    added 10 commits

    Compare with previous version

  • Ghost User marked the checklist item My code follows the code style of this project. as completed

    marked the checklist item My code follows the code style of this project. as completed

  • Ghost User marked the checklist item I have read the CONTRIBUTING document. as completed

    marked the checklist item I have read the CONTRIBUTING document. as completed

  • Ghost User marked the checklist item I have added tests to cover my changes. as completed

    marked the checklist item I have added tests to cover my changes. as completed

  • Ghost User marked the checklist item All new and existing tests passed. as completed

    marked the checklist item All new and existing tests passed. as completed

  • Ghost User added 2 commits

    added 2 commits

    Compare with previous version

  • Ghost User marked this merge request as ready

    marked this merge request as ready

  • Ghost User added 8 commits

    added 8 commits

    Compare with previous version

  • Ghost User marked this merge request as draft from ff928b38

    marked this merge request as draft from ff928b38

  • Ghost User added 1 commit

    added 1 commit

    • 6aacafa6 - Unify marshallDevice interface

    Compare with previous version

  • Ghost User marked this merge request as ready

    marked this merge request as ready

  • Ghost User added 1 commit

    added 1 commit

    • 360f9fb6 - Move lookup table into device store

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    Compare with previous version

  • Ghost User added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading