Let user set a name for a device or autogenerate it
Description
Let user set a name for a device or autogenerate it.
Related Issue
Motivation and Context
Users should have the chance to interact with human readable device names instead of UUIDs only.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I have read the CONTRIBUTING document. -
I have added tests to cover my changes. -
All new and existing tests passed.
Edited by Ghost User
Merge request reports
Activity
131 136 } 132 137 133 138 func (pnd *pndImplementation) addDevice(device *Device) error { 134 return pnd.devices.add(device) 139 err := pnd.devices.add(device) 140 if err != nil { 141 return err 142 } 143 144 pnd.deviceNameToUUIDLookup[device.Name] = device.UUID 145 146 return nil 135 147 } 136 148 137 func (pnd *pndImplementation) getDevice(id uuid.UUID) (*Device, error) { Would leave this as
getDevice()
. It's the default as long as there are no humans involved and should have the cleaner signature. But open to discuss it.Edited by Ghost User
- A deleted user
changed milestone to %SORT
- A deleted user
added ~3086 sort labels
- A deleted user
added componentcli label and removed ~3086 label
added 10 commits
-
1636b4d5...3405158a - 8 commits from branch
develop
- e0790856 - Merge branch 'develop' into istaester/autogenerate-device-names
- 6f5d3cf6 - Add test for getDeviceByName
-
1636b4d5...3405158a - 8 commits from branch
added 2 commits
added 8 commits
-
5110dbdf...a94be2bb - 6 commits from branch
develop
- ff928b38 - WIP
- d3acdec8 - Merge branch 'develop' into istaester/autogenerate-device-names
-
5110dbdf...a94be2bb - 6 commits from branch
marked this merge request as draft from ff928b38
Please register or sign in to reply