Skip to content
Snippets Groups Projects

Commit-Confirm Mechanic for PND

Merged Ghost User requested to merge 99-commit-confirm-mechanic-for-ond-changes into develop

Description

This MR introduces a commit-confirm mechanic for changes to ONDs. A change created in a pending-state. A commit of this change by the operator pushed the change to the given OND. If the commit is not confirmed within 10 minutes (default. Use the GOSDN_CHANGE_TIMEOUT environment variable to change the timeout) is is rolled back automatically.

Related Issue

Closes #99 (closed)

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports

Merge train pipeline #69000 passed with warnings

Merge train pipeline passed with warnings for 2b9b4369

Test coverage 62.40% (9.40%) from 1 job
Approval is optional

Merged by avatar (Apr 23, 2025 3:39am UTC)

Merge details

  • Changes merged into develop with 39617763.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #69003 passed

Pipeline passed for 39617763 on develop

Test coverage 62.30% (9.40%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading