Commit-Confirm Mechanic for PND
Description
This MR introduces a commit-confirm mechanic for changes to ONDs. A change created in a pending
-state. A commit
of this change by the operator pushed the change to the given OND. If the commit
is not confirm
ed within 10 minutes (default. Use the GOSDN_CHANGE_TIMEOUT
environment variable to change the timeout) is is rolled back automatically.
Related Issue
Closes #99 (closed)
Motivation and Context
How Has This Been Tested?
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I have read the CONTRIBUTING document. -
I have added tests to cover my changes. -
All new and existing tests passed.
Merge request reports
Activity
- A deleted user
changed milestone to %v0.1.0 Codename Threadbare
added 6 commits
-
18f46026...5e53f43f - 2 commits from branch
develop
- fd912243 - resolve conflict
- a3600632 - pnd commit confirm test
- 034077f1 - Fix cli parsing of pnd and sbi
- f316d842 - more error handling
Toggle commit list-
18f46026...5e53f43f - 2 commits from branch
enabled automatic add to merge train when the pipeline for 13228298 succeeds
mentioned in commit 39617763
- A deleted user
merged
Please register or sign in to reply