Resolve "Code Quality"
Closes #85 (closed)
Edited by Ghost User
Merge request reports
Activity
- A deleted user
changed milestone to %v0.1.0 Codename Threadbare
added 11 commits
-
f40b245a...19a8499c - 2 commits from branch
develop
- 907bb41c - golangci: ignores now the folders fork and tests
- bca99cb4 - removed plugins folder
- 59aec7f3 - fixing simple linting errors:
- bc9c93f9 - lint error fixes (mainly commenting)
- d84da56a - Merge branch 'develop' into 85-code-quality
- 113cbac5 - refactoring for initialism linting errors
- f2670a0a - ignore nucleus/http.go for linting
- ec3f89b8 - fixed "not 'gofmt'-ed" error
- 35af96dc - fixed linting errors
Toggle commit list-
f40b245a...19a8499c - 2 commits from branch
I wasn't quite sure how to describe the following functions
cli/path_traversal.go:8:1: exported function `PathTraversal` should have comment or be unexported (golint) cli/ygot.go:8:1: exported function `LeafPaths` should have comment or be unexported (golint) cli/http.go:20:1: exported function `HTTPGet` should have comment or be unexported (golint)
For the errors listed below I had tried the
type ctxKeyType string
approach from a blog [1] entry, however I killed the tests with it.cli/subscribe.go:50:9: should not use basic type string as key in context.WithValue (golint) nucleus/gnmi_transport.go:161:8: should not use basic type string as key in context.WithValue (golint) nucleus/gnmi_transport.go:172:8: should not use basic type string as key in context.WithValue (golint)
[1] https://www.calhoun.io/pitfalls-of-context-values-and-how-to-avoid-or-mitigate-them/
added 8 commits
Toggle commit listadded 6 commits
- 890f7094 - gofmt
- 6c6740f4 - fixed initialism linting errors
- 3cbe1d63 - some minor adjustments for context keys
- c38cf281 - Revert "some minor adjustments for context keys"
- 95b602c0 - comments for context keys
- a3651c85 - Merge branch '85-code-quality' of ssh://code.fbi.h-da.de/cocsn/gosdn into 85-code-quality
Toggle commit listadded 6 commits
-
96418bf1 - 1 commit from branch
develop
- d625f7e5 - skip tests because of slice ordering issues
- fc0f18e7 - disable protp tap in set
- c36899a6 - Merge branch '85-code-quality' of code.fbi.h-da.de:cocsn/gosdn into 85-code-quality
- 7a7f7ab5 - Merge branch 'develop' into 85-code-quality
- 4ddb8455 - mitigated data race
Toggle commit list-
96418bf1 - 1 commit from branch
added 2 commits
added 1 commit
- 280a8979 - clear before_script for docker building stages
added 1 commit
- a9b54283 - clear before_script for docker building stages
added 1 commit
- 7934e22f - clear before_script for docker building stages
enabled automatic add to merge train when the pipeline for 7934e22f succeeds
added 1 commit
- bc912ea7 - clear before_script for docker building stages
added 1 commit
- ce80c5f4 - clear before_script for docker building stages
mentioned in commit dd7519aa
- A deleted user
merged
Please register or sign in to reply