Skip to content
Snippets Groups Projects
Commit fa04dbfc authored by Fabian Seidl's avatar Fabian Seidl
Browse files

todo clean up

parent afc43747
No related branches found
No related tags found
1 merge request!416Resolve "Refactor how PNDs are implemented in the code"
Pipeline #137627 failed
...@@ -47,8 +47,6 @@ import ( ...@@ -47,8 +47,6 @@ import (
pb "google.golang.org/protobuf/proto" pb "google.golang.org/protobuf/proto"
) )
// TODO(PND): fix tests "json: unsupported value: encountered a cycle via []*mock.Call", probably because of pndService interface missing change stuff?!
/* /*
Based on this StackOverflow answer: https://stackoverflow.com/a/52080545/4378176 Based on this StackOverflow answer: https://stackoverflow.com/a/52080545/4378176
*/ */
...@@ -196,8 +194,6 @@ func bootstrapUnitTest() { ...@@ -196,8 +194,6 @@ func bootstrapUnitTest() {
networkElementStore := nucleus.NewNetworkElementStore() networkElementStore := nucleus.NewNetworkElementStore()
networkElementService := nucleus.NewNetworkElementService(networkElementStore, pluginService, eventService) networkElementService := nucleus.NewNetworkElementService(networkElementStore, pluginService, eventService)
//TODO(PND): check/fix api_test: getdevice/adddevice, maybe the mne here is not necessary!
mne, _ := nucleus.NewNetworkElement("test", mneUUID, &tpb.TransportOption{ mne, _ := nucleus.NewNetworkElement("test", mneUUID, &tpb.TransportOption{
Address: "test", Address: "test",
Username: "test", Username: "test",
......
...@@ -131,7 +131,6 @@ package server ...@@ -131,7 +131,6 @@ package server
// } // }
// } // }
// // TODO(PND): fix test, problem here is either missing port in transport address or unreachable when address:port is provided.
// // Somehow, provided mock transport does not get used? // // Somehow, provided mock transport does not get used?
// func TestNetworkElementServer_getPath(t *testing.T) { // func TestNetworkElementServer_getPath(t *testing.T) {
// mneServer := &NetworkElementServer{} // mneServer := &NetworkElementServer{}
...@@ -357,8 +356,6 @@ package server ...@@ -357,8 +356,6 @@ package server
// } // }
// } // }
// // TODO(PND): Need to fix test. Probably same problem as in GetPath Test.
// // error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp: missing address"
// func TestNetworkElementServer_Update(t *testing.T) { // func TestNetworkElementServer_Update(t *testing.T) {
// mneServer := &NetworkElementServer{} // mneServer := &NetworkElementServer{}
// createTestNetworkElementServer(t, mneServer) // createTestNetworkElementServer(t, mneServer)
......
...@@ -16,7 +16,6 @@ package server ...@@ -16,7 +16,6 @@ package server
// "github.com/stretchr/testify/mock" // "github.com/stretchr/testify/mock"
// ) // )
// // TODO(PND): this whole file needs to be reworked!
// func getTestPndServer(t *testing.T) *PndServer { // func getTestPndServer(t *testing.T) *PndServer {
// var err error // var err error
// pndUUID, err = uuid.Parse(pndID) // pndUUID, err = uuid.Parse(pndID)
......
...@@ -162,7 +162,6 @@ package integration ...@@ -162,7 +162,6 @@ package integration
// } // }
// } // }
// // TODO(PND): test compilable for now, not working. Changes pnd to n within t.Run method
// func TestGnmi_SetValidIntegration(t *testing.T) { // func TestGnmi_SetValidIntegration(t *testing.T) {
// if testing.Short() { // if testing.Short() {
// t.Skip("skipping integration test") // t.Skip("skipping integration test")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment