Skip to content
Snippets Groups Projects
Commit 5d8bdda6 authored by Katharina Renk's avatar Katharina Renk
Browse files

updated linter version, changed revive linter sensitivity

parent 58e830b7
No related branches found
No related tags found
1 merge request!428updated linter version, changed revive linter sensitivity
Pipeline #134096 failed
This commit is part of merge request !428. Comments created here will be created in the context of that merge request.
variables: variables:
GOLANG_VERSION: "1.20.1" GOLANG_VERSION: "1.20.1"
code-quality: code-quality:
image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/golangci/golangci-lint:v1.46-alpine image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/golangci/golangci-lint:v1.51.2-alpine
stage: analyze stage: analyze
script: script:
# writes golangci-lint output to gl-code-quality-report.json # writes golangci-lint output to gl-code-quality-report.json
......
...@@ -51,10 +51,8 @@ linters: ...@@ -51,10 +51,8 @@ linters:
- typecheck - typecheck
- revive - revive
- whitespace - whitespace
- deadcode
- errcheck - errcheck
- ineffassign - ineffassign
- varcheck
- bidichk - bidichk
- durationcheck - durationcheck
- errorlint - errorlint
...@@ -78,3 +76,6 @@ linters-settings: ...@@ -78,3 +76,6 @@ linters-settings:
# Such cases aren't reported by default. # Such cases aren't reported by default.
# Default: false # Default: false
check-type-assertions: true check-type-assertions: true
revive:
severity: warning
confidence: 0.8
...@@ -28,7 +28,7 @@ install-tools: ...@@ -28,7 +28,7 @@ install-tools:
@echo Install development tooling @echo Install development tooling
mkdir -p $(GOSDN_PRG) mkdir -p $(GOSDN_PRG)
export GOBIN=$(GOSDN_PRG) && go install gotest.tools/gotestsum@v1.8.1 &&\ export GOBIN=$(GOSDN_PRG) && go install gotest.tools/gotestsum@v1.8.1 &&\
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 &&\ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 &&\
go install github.com/vektra/mockery/v2@v2.14.0 &&\ go install github.com/vektra/mockery/v2@v2.14.0 &&\
go install github.com/openconfig/ygot/generator@v0.20.2 &&\ go install github.com/openconfig/ygot/generator@v0.20.2 &&\
go install github.com/andresterba/go-ygot-generator-generator@v0.0.2 go install github.com/andresterba/go-ygot-generator-generator@v0.0.2
......
...@@ -15,7 +15,7 @@ install-tools: ...@@ -15,7 +15,7 @@ install-tools:
@echo Install development tooling @echo Install development tooling
mkdir -p $(GOSDN_PRG) mkdir -p $(GOSDN_PRG)
go install gotest.tools/gotestsum@v1.7.0 go install gotest.tools/gotestsum@v1.7.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46 go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2
go install github.com/vektra/mockery/v2@v2.14.0 go install github.com/vektra/mockery/v2@v2.14.0
@echo Finished installing development tooling @echo Finished installing development tooling
......
code-quality: code-quality:
image: golangci/golangci-lint:v1.46-alpine image: golangci/golangci-lint:v1.51.2-alpine
stage: test stage: test
rules: rules:
- if: $CI_PIPELINE_SOURCE == "merge_request_event" - if: $CI_PIPELINE_SOURCE == "merge_request_event"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment