Skip to content
Snippets Groups Projects
Commit 424240c3 authored by Fabian Seidl's avatar Fabian Seidl
Browse files

adjust tests becasue of breaking changes in update

parent 1edffbf3
No related branches found
No related tags found
1 merge request!1042[renovate] Update module github.com/bufbuild/protovalidate-go to v0.7.0
Pipeline #224768 passed
Stage: build
Stage: build-testing
Stage: test
Stage: analyze
Stage: test-legacy
This commit is part of merge request !1042. Comments created here will be created in the context of that merge request.
Hide whitespace changes
Inline Side-by-side
controller/northbound/server/auth_test.go
+ 6
− 6
Edit View file @ 424240c3
......@@ -89,9 +89,9 @@ func TestAuth_Login(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "username",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("username"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
}},
},
}
......@@ -160,9 +160,9 @@ func TestAuth_Logout(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "username",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("username"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
}},
},
}
......
controller/northbound/server/role_test.go
+ 24
− 24
Edit View file @ 424240c3
......@@ -84,9 +84,9 @@ func TestRole_CreateRoles(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "roles[0].name",
ConstraintId: "string.min_len",
Message: "value length must be at least 3 characters",
FieldPath: stringToPointer("roles[0].name"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 3 characters"),
}},
},
{
......@@ -105,9 +105,9 @@ func TestRole_CreateRoles(t *testing.T) {
want: &apb.CreateRolesResponse{},
wantErr: true,
validationErrors: []*validate.Violation{{
FieldPath: "roles[0].description",
ConstraintId: "string.min_len",
Message: "value length must be at least 3 characters",
FieldPath: stringToPointer("roles[0].description"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 3 characters"),
}},
},
}
......@@ -181,9 +181,9 @@ func TestRole_GetRole(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "role_name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("role_name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......@@ -355,9 +355,9 @@ func TestRole_UpdateRoles(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "roles[0].name",
ConstraintId: "string.min_len",
Message: "value length must be at least 3 characters",
FieldPath: stringToPointer("roles[0].name"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 3 characters"),
},
},
},
......@@ -379,9 +379,9 @@ func TestRole_UpdateRoles(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "roles[0].description",
ConstraintId: "string.min_len",
Message: "value length must be at least 3 characters",
FieldPath: stringToPointer("roles[0].description"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 3 characters"),
},
},
},
......@@ -456,14 +456,14 @@ func TestRole_DeletePermissionsForRole(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "role_name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("role_name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
{
FieldPath: "permissions_to_delete",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("permissions_to_delete"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......@@ -537,9 +537,9 @@ func TestRole_DeleteRoles(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "role_name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("role_name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......
controller/northbound/server/test_util_test.go
+ 4
− 0
Edit View file @ 424240c3
......@@ -305,3 +305,7 @@ func initUUIDs(t *testing.T) {
// _ = mneServer.mneService.Delete(mne)
// }
// }
func stringToPointer(str string) *string {
return &str
}
controller/northbound/server/topology_test.go
+ 18
− 18
Edit View file @ 424240c3
......@@ -285,29 +285,29 @@ func TestTopology_AddLink(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "link.name",
ConstraintId: "string.min_len",
Message: "value length must be at least 1 characters",
FieldPath: stringToPointer("link.name"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 1 characters"),
},
{
FieldPath: "link.sourceNode",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("link.sourceNode"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
{
FieldPath: "link.targetNode",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("link.targetNode"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
{
FieldPath: "link.sourcePort",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("link.sourcePort"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
{
FieldPath: "link.targetPort",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("link.targetPort"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......@@ -461,9 +461,9 @@ func TestTopology_DeleteLink(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "id",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("id"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
}},
},
}
......
controller/northbound/server/user_test.go
+ 15
− 15
Edit View file @ 424240c3
......@@ -90,9 +90,9 @@ func TestUser_CreateUsers(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "user[0].password",
ConstraintId: "string.min_len",
Message: "value length must be at least 5 characters",
FieldPath: stringToPointer("user[0].password"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 5 characters"),
}},
},
{
......@@ -116,9 +116,9 @@ func TestUser_CreateUsers(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "user[0].name",
ConstraintId: "string.min_len",
Message: "value length must be at least 3 characters",
FieldPath: stringToPointer("user[0].name"),
ConstraintId: stringToPointer("string.min_len"),
Message: stringToPointer("value length must be at least 3 characters"),
}},
},
}
......@@ -190,9 +190,9 @@ func TestUser_GetUser(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
}},
},
}
......@@ -341,9 +341,9 @@ func TestUser_UpdateUsers(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......@@ -402,9 +402,9 @@ func TestUser_DeleteUsers(t *testing.T) {
wantErr: true,
validationErrors: []*validate.Violation{
{
FieldPath: "name",
ConstraintId: "required",
Message: "value is required",
FieldPath: stringToPointer("name"),
ConstraintId: stringToPointer("required"),
Message: stringToPointer("value is required"),
},
},
},
......
controller/northbound/server/utils_test.go
+ 1
− 1
Edit View file @ 424240c3
......@@ -9,7 +9,7 @@ import (
func contains(array []*validate.Violation, err *validate.Violation) bool {
for _, v := range array {
if v.FieldPath == err.FieldPath && v.ConstraintId == err.ConstraintId && v.Message == err.Message {
if *v.FieldPath == *err.FieldPath && *v.ConstraintId == *err.ConstraintId && *v.Message == *err.Message {
return true
}
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment