Merge branch 'revert-a181a3de' into 'develop'

Revert "Merge branch '142-add-rules-to-pipelines' into 'develop'"

See merge request !216

.gitlab-ci.yml

@@ -13,19 +13,8 @@ stages:
   - deploy
   - .post
 
-workflow:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "push" && $CI_OPEN_MERGE_REQUESTS'
-      when: never
-    - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
-      when: always
-    - if: '$CI_PIPELINE_SOURCE == "push"'
-      when: always
-    - if: '$CI_PIPELINE_SOURCE == "schedule"'
-      when: always
 
 include:
-  - local: '/.gitlab/ci/.ruleset.yml'
   - local: '/.gitlab/ci/.build-container.yml'
   - local: '/.gitlab/ci/.code-quality-ci.yml'
   - local: '/.gitlab/ci/.security-and-compliance-ci.yml'

.gitlab/ci/.build-container.yml

@@ -21,16 +21,7 @@ build-testing-image:
       variables:
         TAG: develop
         BUILDARGS: -race
-    - !reference [.push_event, rules]
-    - !reference [.merge_request, rules]
-  before_script:
-    # replace all slashes in the tag with hyphen, because slashes are not allowed in tags
-    - TAG=${TAG//\//-}
-    - mkdir -p /kaniko/.docker
-    - echo "{\"auths\":{\"$CI_REGISTRY\":{\"username\":\"$CI_REGISTRY_USER\",\"password\":\"$CI_REGISTRY_PASSWORD\"}}}" >/kaniko/.docker/config.json
-  needs: []
-
-build-testing-image:
+    - when: always
   script:
     - /kaniko/executor
       --cache=true

.gitlab/ci/.code-quality-ci.yml

@@ -9,6 +9,5 @@ code-quality:
       codequality: gl-code-quality-report.json
     paths:
       - gl-code-quality-report.json
-  rules:
-    - !reference [.merge_request, rules]
   needs: []
+  
\ No newline at end of file

.gitlab/ci/.containerlab-ci.yml

@@ -43,8 +43,6 @@ variables:
     name: ${CLAB_NAME}
     paths:
       - ${CLAB_NAME}.clab.yml
-  rules:
-    - !reference [.merge_request, rules]
 
 # JOBS
 containerlab:template:integration:
@@ -68,9 +66,6 @@ containerlab:deploy:integration:
   artifacts:
     reports:
       dotenv: ${CI_PROJECT_DIR}/build.env
-  rules:
-    - !reference [.merge_request, rules]
-
 
 
 containerlab:destroy:
@@ -89,8 +84,6 @@ containerlab:destroy:
     - docker volume rm -f ${CLAB_NAME}-volume
     - docker image rm -f ${GOSDN_IMAGE}
   allow_failure: true
-  rules:
-    - !reference [.containerlab_cleanup, rules]
 
 
 #containerlab:template:develop:

.gitlab/ci/.integration-test.yml

@@ -26,8 +26,6 @@ integration-test:nucleus:
     - go test -race -v -run TestGnmi_GetIntegration
     - go test -race -v -run TestGnmi_SubscribeIntegration
     - go test -race -v -run TestGnmi_CapabilitiesIntegration
-  rules:
-    - !reference [.merge_request, rules]
 
 integration-test:api:
   <<: *integration-test
@@ -36,5 +34,3 @@ integration-test:api:
   script:
     - cd ./api
     - go test -race -v -run TestApiIntegration
-  rules:
-    - !reference [.merge_request, rules]

.gitlab/ci/.ruleset.yml

-.push_event:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "push"'
-      when: on_success
-
-.merge_request:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
-      when: on_success
-
-.containerlab_cleanup:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
-      when: always
-
-.merge_request_and_changed_dependency:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
-      changes:
-        - go.mod
-        - go.sum
-      when: always
-
-.nightly_pipeline:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "schedule"'
-      when: always
-
-.nightly_develop_pipeline:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "schedule"  && $CI_NIGHTLY == "develop"'
-      when: always
-
-.nightly_main_pipeline:
-  rules:
-    - if: '$CI_PIPELINE_SOURCE == "schedule"  && $CI_NIGHTLY == "mainline"'
-      when: always

.gitlab/ci/.security-and-compliance-ci.yml

@@ -16,24 +16,23 @@ include:
   - template: Security/SAST.gitlab-ci.yml
   - template: Dependency-Scanning.gitlab-ci.yml
   - template: Security/License-Scanning.gitlab-ci.yml
-  #  - template: Security/Secret-Detection.gitlab-ci.yml
+#  - template: Security/Secret-Detection.gitlab-ci.yml
   - template: Security/Container-Scanning.gitlab-ci.yml
 
-license_scanning:
-  rules:
-    - !reference [.merge_request_and_changed_dependency, rules]
-
 gemnasium-dependency_scanning:
-  rules:
-    - !reference [.merge_request_and_changed_dependency, rules]
+  <<: *rules
 
 gosec-sast:
-  rules:
-    - !reference [.nightly_pipeline, rules]
+  <<: *rules
+
+license_scanning:
+  <<: *rules
 
 semgrep-sast:
-  rules:
-    - !reference [.nightly_pipeline, rules]
+  <<: *rules
+
+#secret_detection:
+#  <<: *rules
 
 container_scanning:
   stage: analyze
@@ -45,5 +44,5 @@ container_scanning:
     DOCKER_IMAGE: "${GOSDN_IMAGE}"
     DOCKER_USER: "${CI_REGISTRY_USER}"
     DOCKER_PASSWORD: "${CI_REGISTRY_PASSWORD}"
-  needs:
+  needs: 
     - build-image

.gitlab/ci/.test.yml

@@ -21,16 +21,11 @@ unit-test:
   after_script:
     - go tool cover -func=coverage.out
   <<: *test
-  rules:
-    - !reference [.push_event, rules]
-    - !reference [.merge_request, rules]
 
 controller-test:
   script:
     - gotestsum --junitfile report.xml --format testname -- -race -v -run TestRun
   <<: *test
-  rules:
-    - !reference [.merge_request, rules]
 
 test-build:
   artifacts: