Enable goimports linter

build/ci/.golangci-config/.golangci.yml

@@ -26,8 +26,11 @@ linters:
   disable-all: true
   enable:
     - gofmt
+    - goimports
     - golint
     - gocyclo
     - govet
 issues:
   exclude-use-default: false
+  max-issues-per-linter: 0
+  max-same-issues: 0
\ No newline at end of file

cli/capabilities.go

 package cli
 
 import (
-	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
-	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
 	"context"
 	"fmt"
-	gpb "github.com/openconfig/gnmi/proto/gnmi"
 	"strings"
+
+	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
+	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
+	gpb "github.com/openconfig/gnmi/proto/gnmi"
 )
 
 // Capabilities sends a gNMI Capabilities request to the specified target

cli/get.go

 package cli
 
 import (
+	"context"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
-	"context"
 	gpb "github.com/openconfig/gnmi/proto/gnmi"
 	log "github.com/sirupsen/logrus"
 )

cli/set.go

 package cli
 
 import (
+	"context"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
-	"context"
 )
 
 // Set sends a gNMI Set request to the specified target. Only one

cli/subscribe.go

 package cli
 
 import (
-	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
-	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
 	"context"
 	"fmt"
-	gpb "github.com/openconfig/gnmi/proto/gnmi"
-	log "github.com/sirupsen/logrus"
 	"os"
 	"os/signal"
 	"syscall"
 	"time"
+
+	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
+	"code.fbi.h-da.de/cocsn/gosdn/nucleus"
+	gpb "github.com/openconfig/gnmi/proto/gnmi"
+	log "github.com/sirupsen/logrus"
 )
 
 // Subscribe starts a gNMI subscriber requersting the specified paths on the target and

cli/target.go

 package cli
 
 import (
+	"context"
+	"net"
+	"reflect"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/google/gnmi"
 	oc "code.fbi.h-da.de/cocsn/yang-models/generated/openconfig"
-	"context"
 	pb "github.com/openconfig/gnmi/proto/gnmi"
 	"github.com/openconfig/goyang/pkg/yang"
 	"github.com/openconfig/ygot/util"
@@ -11,8 +14,6 @@ import (
 	log "github.com/sirupsen/logrus"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/reflection"
-	"net"
-	"reflect"
 )
 
 type server struct {

cmd/util.go

@@ -33,6 +33,7 @@ package cmd
 
 import (
 	"errors"
+
 	"github.com/spf13/cobra"
 )
 

database/client.go

@@ -2,6 +2,7 @@ package database
 
 import (
 	"errors"
+
 	"github.com/neo4j/neo4j-go-driver/neo4j"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/viper"

nucleus/controller.go

 package nucleus
 
 import (
-	"code.fbi.h-da.de/cocsn/gosdn/database"
 	"context"
-	"github.com/google/uuid"
-	log "github.com/sirupsen/logrus"
 	"net/http"
 	"os"
 	"os/signal"
 	"sync"
 	"time"
+
+	"code.fbi.h-da.de/cocsn/gosdn/database"
+	"github.com/google/uuid"
+	log "github.com/sirupsen/logrus"
 )
 
 var coreLock sync.RWMutex

nucleus/device_test.go

 package nucleus
 
 import (
+	"reflect"
+	"testing"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	"code.fbi.h-da.de/cocsn/yang-models/generated/openconfig"
 	"github.com/google/uuid"
 	"github.com/openconfig/ygot/ygot"
-	"reflect"
-	"testing"
 )
 
 func TestDevice_Id(t *testing.T) {

nucleus/gnmi_transport.go

 package nucleus
 
 import (
+	"context"
+	"reflect"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	pathutils "code.fbi.h-da.de/cocsn/gosdn/nucleus/util/path"
-	"context"
 	gpb "github.com/openconfig/gnmi/proto/gnmi"
 	"github.com/openconfig/gnmi/proto/gnmi_ext"
 	"github.com/openconfig/goyang/pkg/yang"
 	"github.com/openconfig/ygot/ygot"
 	"github.com/openconfig/ygot/ytypes"
 	log "github.com/sirupsen/logrus"
-	"reflect"
 )
 
 // CtxKeyType is a custom type to be used as key in a context.WithValue() or

nucleus/gnmi_transport_test.go

 package nucleus
 
 import (
+	"context"
+	"errors"
+	"reflect"
+	"testing"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	"code.fbi.h-da.de/cocsn/gosdn/mocks"
 	"code.fbi.h-da.de/cocsn/yang-models/generated/openconfig"
-	"context"
-	"errors"
 	gpb "github.com/openconfig/gnmi/proto/gnmi"
 	"github.com/openconfig/gnmi/proto/gnmi_ext"
 	"github.com/openconfig/goyang/pkg/yang"
 	"github.com/openconfig/ygot/ytypes"
 	"github.com/stretchr/testify/mock"
-	"reflect"
-	"testing"
 )
 
 // testSetupGnmi bootstraps tests for gnmi transport

nucleus/http_test.go

 package nucleus
 
 import (
-	"code.fbi.h-da.de/cocsn/gosdn/mocks"
 	"errors"
+	"net/http"
+	"testing"
+
+	"code.fbi.h-da.de/cocsn/gosdn/mocks"
 	"github.com/google/uuid"
 	log "github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/mock"
-	"net/http"
-	"testing"
 )
 
 func testSetupHTTP() {

nucleus/initialise_test.go

 package nucleus
 
 import (
+	"context"
+	"os"
+	"testing"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	"code.fbi.h-da.de/cocsn/gosdn/mocks"
 	"code.fbi.h-da.de/cocsn/gosdn/nucleus/util/proto"
 	"code.fbi.h-da.de/cocsn/gosdn/test"
-	"context"
 	"github.com/google/uuid"
 	gpb "github.com/openconfig/gnmi/proto/gnmi"
 	log "github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/mock"
 	pb "google.golang.org/protobuf/proto"
-	"os"
-	"testing"
 )
 
 const apiEndpoint = "http://localhost:8080"

nucleus/pnd/change.go

@@ -2,13 +2,14 @@ package pnd
 
 import (
 	"errors"
+	"os"
+	"sync"
+	"time"
+
 	"github.com/google/uuid"
 	"github.com/openconfig/ygot/ygot"
 	log "github.com/sirupsen/logrus"
 	"golang.org/x/net/context"
-	"os"
-	"sync"
-	"time"
 )
 
 var changeTimeout time.Duration

nucleus/pnd/change_test.go

@@ -3,13 +3,14 @@ package pnd
 import (
 	"context"
 	"errors"
-	"github.com/google/uuid"
-	"github.com/openconfig/ygot/exampleoc"
-	"github.com/openconfig/ygot/ygot"
 	"reflect"
 	"sync"
 	"testing"
 	"time"
+
+	"github.com/google/uuid"
+	"github.com/openconfig/ygot/exampleoc"
+	"github.com/openconfig/ygot/ygot"
 )
 
 var commit = "commit"

nucleus/pnd/initialise_test.go

 package pnd
 
 import (
-	"github.com/google/uuid"
-	log "github.com/sirupsen/logrus"
 	"os"
 	"testing"
+
+	"github.com/google/uuid"
+	log "github.com/sirupsen/logrus"
 )
 
 // UUIDs for test cases

nucleus/principalNetworkDomain.go

 package nucleus
 
 import (
+	"context"
+
 	"code.fbi.h-da.de/cocsn/gosdn/forks/goarista/gnmi"
 	. "code.fbi.h-da.de/cocsn/gosdn/nucleus/pnd" //nolint
-	"context"
 	"github.com/openconfig/ygot/ygot"
 	"github.com/openconfig/ygot/ytypes"
 	log "github.com/sirupsen/logrus"
 
 	"encoding/json"
+
 	"github.com/google/uuid"
 )
 

nucleus/principalNetworkDomain_test.go

 package nucleus
 
 import (
+	"errors"
+	"reflect"
+	"testing"
+
 	"code.fbi.h-da.de/cocsn/gosdn/mocks"
 	"code.fbi.h-da.de/cocsn/yang-models/generated/openconfig"
-	"errors"
 	"github.com/google/uuid"
 	"github.com/openconfig/ygot/ygot"
 	"github.com/stretchr/testify/mock"
-	"reflect"
-	"testing"
 )
 
 func TestNewPND(t *testing.T) {

nucleus/restconf_transport.go

@@ -2,6 +2,7 @@ package nucleus
 
 import (
 	"context"
+
 	"github.com/openconfig/ygot/ytypes"
 )