Skip to content
Snippets Groups Projects
Commit 10f42412 authored by Fabian Seidl's avatar Fabian Seidl
Browse files

tests for autg api

parent f0d4d76d
No related branches found
No related tags found
1 merge request!287Implement data persisting for user management
Hide whitespace changes
Inline Side-by-side
controller/northbound/server/auth.go
+ 6
− 0
View file @ 10f42412
...@@ -2,6 +2,7 @@ package server ...@@ -2,6 +2,7 @@ package server
import ( import (
"context" "context"
"fmt"
"time" "time"
apb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/rbac" apb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/rbac"
...@@ -125,6 +126,9 @@ func (s Auth) GetUser(ctx context.Context, request *apb.GetUserRequest) (*apb.Ge ...@@ -125,6 +126,9 @@ func (s Auth) GetUser(ctx context.Context, request *apb.GetUserRequest) (*apb.Ge
start := metrics.StartHook(labels, grpcRequestsTotal) start := metrics.StartHook(labels, grpcRequestsTotal)
defer metrics.FinishHook(labels, start, grpcRequestDurationSecondsTotal, grpcRequestDurationSeconds) defer metrics.FinishHook(labels, start, grpcRequestDurationSecondsTotal, grpcRequestDurationSeconds)
usersA, _ := userc.GetAll()
fmt.Printf("%+v", usersA)
// TODO: implement check if user is allowed to get this user data; only their own if not admin // TODO: implement check if user is allowed to get this user data; only their own if not admin
userData, err := userc.Get(store.Query{Name: request.Name}) userData, err := userc.Get(store.Query{Name: request.Name})
if err != nil { if err != nil {
...@@ -230,6 +234,8 @@ func (s Auth) isValidUser(user rbac.User) (bool, error) { ...@@ -230,6 +234,8 @@ func (s Auth) isValidUser(user rbac.User) (bool, error) {
storedUser, err := userc.Get(store.Query{Name: user.Name()}) storedUser, err := userc.Get(store.Query{Name: user.Name()})
if err != nil { if err != nil {
return false, err return false, err
} else if storedUser == nil {
return false, status.Errorf(codes.Aborted, "no user object")
} }
if storedUser.Name() == user.Name() { if storedUser.Name() == user.Name() {
......
controller/northbound/server/auth_test.go
+ 681
− 76
View file @ 10f42412
...@@ -4,13 +4,22 @@ import ( ...@@ -4,13 +4,22 @@ import (
"context" "context"
"reflect" "reflect"
"testing" "testing"
"time"
apb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/rbac" apb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/rbac"
"code.fbi.h-da.de/danet/gosdn/controller/rbac" "code.fbi.h-da.de/danet/gosdn/controller/rbac"
"github.com/google/uuid"
) )
func Test_auth_Login(t *testing.T) { const adminID = "5c248a22-8eb7-48cf-b392-45680a1863a5"
const userID = "57005d13-7a4d-493d-a02b-50ca51c40197"
const adminRoleID = "126683ae-5ff2-43ee-92f7-0e2b936f8c77"
const randomRoleName = "bertram"
var adminRoleMap = map[string]string{pndID: "admin"}
var userRoleMap = map[string]string{pndID: "user"}
var jwt *rbac.JWTManager
func TestAuth_Login(t *testing.T) {
type args struct { type args struct {
ctx context.Context ctx context.Context
request *apb.LoginRequest request *apb.LoginRequest
...@@ -21,112 +30,187 @@ func Test_auth_Login(t *testing.T) { ...@@ -21,112 +30,187 @@ func Test_auth_Login(t *testing.T) {
want string want string
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases.
{ {
name: "login test", name: "default login",
want: "testAdmin",
args: args{
request: &apb.LoginRequest{
Username: "testAdmin",
Pwd: "admin",
},
},
wantErr: false,
},
{
name: "login fail wrong pwd",
want: "", want: "",
args: args{ args: args{
request: &apb.LoginRequest{}, request: &apb.LoginRequest{
Username: "testAdmin",
Pwd: "nope",
},
}, },
wantErr: true, wantErr: true,
}, },
} }
jwt := rbac.NewJWTManager("", 1*time.Minute)
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ r := Auth{
UnimplementedAuthServiceServer: apb.UnimplementedAuthServiceServer{}, jwtManager: jwt,
jwtManager: jwt,
} }
resp, err := r.Login(tt.args.ctx, tt.args.request) resp, err := r.Login(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.Login() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.Login() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
got := resp.GetStatus().String() if resp != nil {
got = "" got := resp.Token
if got == "" {
if !reflect.DeepEqual(got, tt.want) { t.Errorf("Auth.Login() = %v, want non empty token", got)
t.Errorf("rbac.Login() = %v, want %v", got, tt.want) }
} }
}) })
} }
} }
func Test_auth_Logout(t *testing.T) { func TestAuth_Logout(t *testing.T) {
type fields struct {
UnimplementedAuthServiceServer apb.UnimplementedAuthServiceServer
}
type args struct { type args struct {
ctx context.Context ctx context.Context
request *apb.LogoutRequest request *apb.LogoutRequest
} }
tests := []struct { tests := []struct {
name string name string
fields fields
args args args args
want *apb.LogoutResponse want *apb.LogoutResponse
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases. // TODO: Add test cases.
// Implement after session hdanling was added
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ s := Auth{}
UnimplementedAuthServiceServer: tt.fields.UnimplementedAuthServiceServer, got, err := s.Logout(tt.args.ctx, tt.args.request)
}
got, err := r.Logout(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.Logout() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.Logout() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
if !reflect.DeepEqual(got, tt.want) { if !reflect.DeepEqual(got, tt.want) {
t.Errorf("rbac.Logout() = %v, want %v", got, tt.want) t.Errorf("Auth.Logout() = %v, want %v", got, tt.want)
} }
}) })
} }
} }
func Test_rbac_CreateUsers(t *testing.T) { func TestAuth_CreateUsers(t *testing.T) {
type fields struct {
UnimplementedAuthServiceServer apb.UnimplementedAuthServiceServer
}
type args struct { type args struct {
ctx context.Context ctx context.Context
request *apb.CreateUsersRequest request *apb.CreateUsersRequest
} }
tests := []struct { tests := []struct {
name string name string
fields fields
args args args args
want *apb.CreateUsersResponse want apb.Status
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases. {
name: "default create users",
args: args{ctx: context.TODO(),
request: &apb.CreateUsersRequest{
User: []*apb.User{
{
Name: "asdf",
Roles: map[string]string{pndID: "asdf"},
Password: "asdf",
Token: "",
},
},
},
},
want: apb.Status_STATUS_OK,
wantErr: false,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ s := Auth{}
UnimplementedAuthServiceServer: tt.fields.UnimplementedAuthServiceServer, got, err := s.CreateUsers(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.CreateUsers() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(got.Status, tt.want) {
t.Errorf("Auth.CreateUsers() = %v, want %v", got, tt.want)
} }
got, err := r.CreateUsers(tt.args.ctx, tt.args.request) })
}
}
func TestAuth_GetUser(t *testing.T) {
type args struct {
ctx context.Context
request *apb.GetUserRequest
}
tests := []struct {
name string
args args
want *apb.GetUserResponse
wantErr bool
}{
{
name: "default get user",
args: args{
ctx: context.TODO(),
request: &apb.GetUserRequest{
Name: "testAdmin",
},
},
want: &apb.GetUserResponse{Status: apb.Status_STATUS_OK,
User: &apb.User{Id: adminID,
Name: "testAdmin"}},
wantErr: false,
},
{
name: "fail get user",
args: args{
ctx: context.TODO(),
request: &apb.GetUserRequest{
Name: "nope",
},
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.GetUser(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.CreateUsers() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.GetUser() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("rbac.CreateUsers() = %v, want %v", got, tt.want) if got != nil && got.Status == tt.want.Status {
if got.User.Name != tt.want.User.Name || got.User.Id != tt.want.User.Id {
t.Errorf("Auth.GetUser() = %v, want %v", got, tt.want)
}
} else {
if got != nil {
t.Errorf("Auth.GetUser() = %v, want %v", got, tt.want)
}
} }
}) })
} }
} }
func Test_rbac_GetUsers(t *testing.T) { func TestAuth_GetUsers(t *testing.T) {
type fields struct { err := clearAndCreateAuthTestSetup()
UnimplementedAuthServiceServer apb.UnimplementedAuthServiceServer if err != nil {
t.Fatalf("%v", err)
} }
type args struct { type args struct {
ctx context.Context ctx context.Context
...@@ -134,94 +218,615 @@ func Test_rbac_GetUsers(t *testing.T) { ...@@ -134,94 +218,615 @@ func Test_rbac_GetUsers(t *testing.T) {
} }
tests := []struct { tests := []struct {
name string name string
fields fields
args args args args
want *apb.GetUsersResponse want *apb.GetUsersResponse
wantLen int
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases. {
name: "default get users",
args: args{ctx: context.TODO(),
request: &apb.GetUsersRequest{},
},
want: &apb.GetUsersResponse{Status: apb.Status_STATUS_OK,
User: []*apb.User{
{Name: "testAdmin"},
{Name: "testUser"},
{Name: "testRandom"}},
},
wantLen: 3,
wantErr: false,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ s := Auth{}
UnimplementedAuthServiceServer: tt.fields.UnimplementedAuthServiceServer, got, err := s.GetUsers(tt.args.ctx, tt.args.request)
}
got, err := r.GetUsers(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.GetUsers() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.GetUsers() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("rbac.GetUsers() = %v, want %v", got, tt.want) if got != nil && got.Status == apb.Status_STATUS_OK {
if len(got.User) != tt.wantLen {
t.Errorf("Auth.GetUsers() = %v, want %v", got, tt.want)
}
for _, gotU := range got.User {
containsExpected := false
for _, wantU := range tt.want.User {
if gotU.Name == wantU.Name {
containsExpected = true
break
}
}
if !containsExpected {
t.Errorf("Auth.GetUsers() = %v, want %v", got, tt.want)
}
}
} }
}) })
} }
} }
func Test_rbac_UpdateUsers(t *testing.T) { func TestAuth_UpdateUsers(t *testing.T) {
type fields struct {
UnimplementedAuthServiceServer apb.UnimplementedAuthServiceServer
}
type args struct { type args struct {
ctx context.Context ctx context.Context
request *apb.UpdateUsersRequest request *apb.UpdateUsersRequest
} }
tests := []struct { tests := []struct {
name string name string
fields fields
args args args args
want *apb.UpdateUsersResponse want *apb.UpdateUsersResponse
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases. {
name: "default update user",
args: args{ctx: context.TODO(),
request: &apb.UpdateUsersRequest{User: []*apb.User{
{Id: adminID,
Name: "sth Else"},
},
},
},
want: &apb.UpdateUsersResponse{
Status: apb.Status_STATUS_OK},
wantErr: false,
},
{
name: "error update user",
args: args{ctx: context.TODO(),
request: &apb.UpdateUsersRequest{User: []*apb.User{
{Id: uuid.NewString(),
Name: "not a user"},
},
},
},
want: nil,
wantErr: true,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ s := Auth{}
UnimplementedAuthServiceServer: tt.fields.UnimplementedAuthServiceServer, got, err := s.UpdateUsers(tt.args.ctx, tt.args.request)
}
got, err := r.UpdateUsers(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.UpdateUsers() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.UpdateUsers() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
if !reflect.DeepEqual(got, tt.want) { if got != nil && got.Status != tt.want.Status {
t.Errorf("rbac.UpdateUsers() = %v, want %v", got, tt.want) t.Errorf("Auth.UpdateUsers() = %v, want %v", got, tt.want)
} }
}) })
} }
} }
func Test_rbac_DeleteUsers(t *testing.T) { func TestAuth_DeleteUsers(t *testing.T) {
type fields struct {
UnimplementedAuthServiceServer apb.UnimplementedAuthServiceServer
}
type args struct { type args struct {
ctx context.Context ctx context.Context
request *apb.DeleteUsersRequest request *apb.DeleteUsersRequest
} }
tests := []struct { tests := []struct {
name string name string
fields fields
args args args args
want *apb.DeleteUsersResponse want *apb.DeleteUsersResponse
wantErr bool wantErr bool
}{ }{
// TODO: Add test cases. {
name: "default delete users",
args: args{ctx: context.TODO(),
request: &apb.DeleteUsersRequest{Username: []string{"testUser"}},
},
want: &apb.DeleteUsersResponse{Status: apb.Status_STATUS_OK},
wantErr: false,
},
{
name: "error delete users",
args: args{ctx: context.TODO(),
request: &apb.DeleteUsersRequest{Username: []string{"no user"}},
},
want: &apb.DeleteUsersResponse{Status: apb.Status_STATUS_OK},
wantErr: true,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
r := Auth{ s := Auth{}
UnimplementedAuthServiceServer: tt.fields.UnimplementedAuthServiceServer, got, err := s.DeleteUsers(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.DeleteUsers() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status != tt.want.Status {
t.Errorf("Auth.DeleteUsers() = %v, want %v", got, tt.want)
} }
got, err := r.DeleteUsers(tt.args.ctx, tt.args.request) })
}
}
func TestAuth_CreateRoles(t *testing.T) {
type args struct {
ctx context.Context
request *apb.CreateRolesRequest
}
tests := []struct {
name string
args args
want *apb.CreateRolesResponse
wantErr bool
}{
{
name: "default create roles",
args: args{ctx: context.TODO(),
request: &apb.CreateRolesRequest{
Roles: []*apb.Role{
{
Name: "new role 1",
Description: "Role 1",
Permissions: []string{"permission 1", "permission 2"},
},
},
},
},
want: &apb.CreateRolesResponse{Status: apb.Status_STATUS_OK},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.CreateRoles(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr { if (err != nil) != tt.wantErr {
t.Errorf("rbac.DeleteUsers() error = %v, wantErr %v", err, tt.wantErr) t.Errorf("Auth.CreateRoles() error = %v, wantErr %v", err, tt.wantErr)
return return
} }
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("rbac.DeleteUsers() = %v, want %v", got, tt.want) if got != nil && got.Status != tt.want.Status {
t.Errorf("Auth.CreateRoles() = %v, want %v", got, tt.want)
} }
}) })
} }
} }
func TestAuth_GetRole(t *testing.T) {
type args struct {
ctx context.Context
request *apb.GetRoleRequest
}
tests := []struct {
name string
args args
want *apb.GetRoleResponse
wantErr bool
}{
{
name: "default get role",
args: args{
ctx: context.TODO(),
request: &apb.GetRoleRequest{
RoleName: "adminTestRole",
},
},
want: &apb.GetRoleResponse{
Role: &apb.Role{
Name: "adminTestRole",
Description: "Admin",
},
Status: apb.Status_STATUS_OK,
},
wantErr: false,
},
{
name: "error get role",
args: args{
ctx: context.TODO(),
request: &apb.GetRoleRequest{
RoleName: "not role",
},
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.GetRole(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.GetRole() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status == tt.want.Status {
if got.Role.Name != tt.want.Role.Name || got.Role.Description != tt.want.Role.Description {
t.Errorf("Auth.GetRole() = %v, want %v", got, tt.want)
}
} else {
if got != nil {
t.Errorf("Auth.GetRole() = %v, want %v", got, tt.want)
}
}
})
}
}
func TestAuth_GetRoles(t *testing.T) {
err := clearAndCreateAuthTestSetup()
if err != nil {
t.Fatalf("%v", err)
}
type args struct {
ctx context.Context
request *apb.GetRolesRequest
}
tests := []struct {
name string
args args
want *apb.GetRolesResponse
wantLen int
wantErr bool
}{
{
name: "default get roles",
args: args{
ctx: context.TODO(),
request: &apb.GetRolesRequest{},
},
want: &apb.GetRolesResponse{
Status: apb.Status_STATUS_OK,
Roles: []*apb.Role{
{
Name: "adminTestRole",
Description: "Admin",
Permissions: []string{
"/gosdn.core.CoreService/GetPnd",
"/gosdn.core.CoreService/GetPndList",
}},
{
Name: "userTestRole",
Description: "User",
Permissions: []string{
"/gosdn.pnd.PndService/GetChangeList",
}},
{
Name: randomRoleName,
Description: "Not a role",
Permissions: []string{
"nope",
},
},
},
},
wantLen: 3,
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.GetRoles(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.GetRoles() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status == tt.want.Status {
if len(got.Roles) != 3 {
t.Errorf("Auth.GetRoles() = %v, want %v", got, tt.want)
}
for _, gotR := range got.Roles {
containsExpected := false
for _, wantR := range tt.want.Roles {
gotPerm := gotR.Permissions
wantPerm := wantR.Permissions
if gotR.Description == wantR.Description && gotR.Name == wantR.Name &&
reflect.DeepEqual(gotPerm, wantPerm) {
containsExpected = true
break
}
}
if !containsExpected {
t.Errorf("Auth.GetRoles() = %v, want %v", got, tt.want)
}
}
}
})
}
}
func TestAuth_UpdateRoles(t *testing.T) {
type args struct {
ctx context.Context
request *apb.UpdateRolesRequest
}
tests := []struct {
name string
args args
want *apb.UpdateRolesResponse
wantErr bool
}{
{
name: "default update roles",
args: args{
ctx: context.TODO(),
request: &apb.UpdateRolesRequest{
Roles: []*apb.Role{
{
Id: adminRoleID,
Name: "New Name",
},
},
},
},
want: &apb.UpdateRolesResponse{
Status: apb.Status_STATUS_OK,
},
wantErr: false,
},
{
name: "error update roles",
args: args{
ctx: context.TODO(),
request: &apb.UpdateRolesRequest{
Roles: []*apb.Role{
{
Id: uuid.NewString(),
Name: "New Name",
},
},
},
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.UpdateRoles(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.UpdateRoles() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status != tt.want.Status {
t.Errorf("Auth.UpdateRoles() = %v, want %v", got, tt.want)
}
})
}
}
func TestAuth_DeletePermissionsForRole(t *testing.T) {
type args struct {
ctx context.Context
request *apb.DeletePermissionsForRoleRequest
}
tests := []struct {
name string
args args
want *apb.DeletePermissionsForRoleResponse
wantErr bool
}{
{
name: "default delete permissions for role",
args: args{
ctx: context.TODO(),
request: &apb.DeletePermissionsForRoleRequest{
RoleName: "adminTestRole",
PermissionsToDelete: []string{
"/gosdn.core.CoreService/GetPnd",
"/gosdn.core.CoreService/GetPndList",
},
},
},
want: &apb.DeletePermissionsForRoleResponse{
Status: apb.Status_STATUS_OK,
},
wantErr: false,
},
{
name: "error delete permissions for role no proper permissions provided",
args: args{
ctx: context.TODO(),
request: &apb.DeletePermissionsForRoleRequest{
RoleName: "adminTestRole",
PermissionsToDelete: []string{
"no",
},
},
},
want: &apb.DeletePermissionsForRoleResponse{
Status: apb.Status_STATUS_OK,
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.DeletePermissionsForRole(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.DeletePermissionsForRole() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status != tt.want.Status {
t.Errorf("Auth.DeletePermissionsForRole() = %v, want %v", got, tt.want)
}
})
}
}
func TestAuth_DeleteRoles(t *testing.T) {
type args struct {
ctx context.Context
request *apb.DeleteRolesRequest
}
tests := []struct {
name string
args args
want *apb.DeleteRolesResponse
wantErr bool
}{
{
name: "default delete roles",
args: args{
ctx: context.TODO(),
request: &apb.DeleteRolesRequest{
RoleName: []string{
"userTestRole",
},
},
},
want: &apb.DeleteRolesResponse{
Status: apb.Status_STATUS_OK,
},
wantErr: false,
},
{
name: "error delete roles",
args: args{
ctx: context.TODO(),
request: &apb.DeleteRolesRequest{
RoleName: []string{
"no",
},
},
},
want: &apb.DeleteRolesResponse{
Status: apb.Status_STATUS_OK,
},
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
s := Auth{}
got, err := s.DeleteRoles(tt.args.ctx, tt.args.request)
if (err != nil) != tt.wantErr {
t.Errorf("Auth.DeleteRoles() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != nil && got.Status != tt.want.Status {
t.Errorf("Auth.DeleteRoles() = %v, want %v", got, tt.want)
}
})
}
}
func clearAndCreateAuthTestSetup() error {
//clear setup if changed
storedUsers, err := userc.GetAll()
if err != nil {
return err
}
for _, u := range storedUsers {
err = userc.Delete(u)
if err != nil {
return err
}
}
storedRoles, err := rolec.GetAll()
if err != nil {
return err
}
for _, r := range storedRoles {
err = rolec.Delete(r)
if err != nil {
return err
}
}
// create dataset
err = createTestUsers()
if err != nil {
return err
}
err = createTestRoles()
if err != nil {
return err
}
return nil
}
//TODO(faseid): change password to hashed/encrypted one
func createTestUsers() error {
randomRoleMap := map[string]string{pndID: randomRoleName}
users := []rbac.User{
{UserID: uuid.MustParse(adminID), UserName: "testAdmin", Roles: adminRoleMap, Password: "admin"},
{UserID: uuid.MustParse(userID), UserName: "testUser", Roles: userRoleMap, Password: "user"},
{UserID: uuid.New(), UserName: "testRandom", Roles: randomRoleMap, Password: "aurelius", Token: "wrong token"},
}
for _, u := range users {
err := userc.Add(rbac.NewUser(u.ID(), u.Name(), u.Roles, u.Password, ""))
if err != nil {
return err
}
}
return nil
}
func createTestRoles() error {
roles := []rbac.Role{
{
RoleID: uuid.MustParse(adminRoleID),
RoleName: "adminTestRole",
Description: "Admin",
Permissions: []string{
"/gosdn.core.CoreService/GetPnd",
"/gosdn.core.CoreService/GetPndList",
},
},
{
RoleID: uuid.New(),
RoleName: "userTestRole",
Description: "User",
Permissions: []string{
"/gosdn.pnd.PndService/GetChangeList",
},
},
{
RoleID: uuid.New(),
RoleName: randomRoleName,
Description: "Not a role",
Permissions: []string{
"nope",
},
},
}
for _, r := range roles {
err := rolec.Add(rbac.NewRole(r.ID(), r.Name(), r.Description, r.Permissions))
if err != nil {
return err
}
}
return nil
}
controller/northbound/server/pnd_test.go
+ 7
− 0
View file @ 10f42412
...@@ -46,6 +46,7 @@ var deviceUUID uuid.UUID ...@@ -46,6 +46,7 @@ var deviceUUID uuid.UUID
var mockPnd *mocks.NetworkDomain var mockPnd *mocks.NetworkDomain
var mockDevice device.Device var mockDevice device.Device
var sbiStore southbound.SbiStore var sbiStore southbound.SbiStore
var mockJwt *rbac.JWTManager
func callback(id uuid.UUID, ch chan device.Details) { func callback(id uuid.UUID, ch chan device.Details) {
// Need for pnd creation, but not needed for this test case. // Need for pnd creation, but not needed for this test case.
...@@ -148,8 +149,14 @@ func TestMain(m *testing.M) { ...@@ -148,8 +149,14 @@ func TestMain(m *testing.M) {
log.Fatal(err) log.Fatal(err)
} }
// everyting auth related
userc = rbac.NewUserStore() userc = rbac.NewUserStore()
rolec = rbac.NewRoleStore() rolec = rbac.NewRoleStore()
err = clearAndCreateAuthTestSetup()
if err != nil {
log.Fatal(err)
}
jwt = rbac.NewJWTManager("", 1*time.Minute)
os.Exit(m.Run()) os.Exit(m.Run())
} }
......
controller/store/genericStore.go
+ 5
− 3
View file @ 10f42412
package store package store
import ( import (
"errors"
"github.com/google/uuid" "github.com/google/uuid"
) )
...@@ -26,7 +28,7 @@ func NewGenericStore[T storableConstraint]() GenericStore[T] { ...@@ -26,7 +28,7 @@ func NewGenericStore[T storableConstraint]() GenericStore[T] {
func (t *GenericStore[T]) Add(item T) error { func (t *GenericStore[T]) Add(item T) error {
_, ok := t.Store[item.ID()] _, ok := t.Store[item.ID()]
if ok { if ok {
return nil return errors.New("item not found")
} }
t.Store[item.ID()] = item t.Store[item.ID()] = item
...@@ -60,12 +62,12 @@ func (t *GenericStore[T]) Get(query Query) (T, error) { ...@@ -60,12 +62,12 @@ func (t *GenericStore[T]) Get(query Query) (T, error) {
// Second search for name // Second search for name
id, ok := t.nameLookupTable[query.Name] id, ok := t.nameLookupTable[query.Name]
if !ok { if !ok {
return *new(T), nil return *new(T), errors.New("item not found")
} }
item, ok := t.Store[id] item, ok := t.Store[id]
if !ok { if !ok {
return *new(T), nil return *new(T), errors.New("item not found")
} }
return item, nil return item, nil
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment