Skip to content
Snippets Groups Projects
  • Than McIntosh's avatar
    8bd803fd
    cmd/internal/sys: migrate support.go functions to new internal pkg · 8bd803fd
    Than McIntosh authored
    Separate out the functions from cmd/internal/sys/support.go and
    migrate them to a new package internal/platform, so that functions such as
    "RaceDetectorSupported" can be called from tests in std as well as in
    cmd. This isn't a complete move of everything in cmd/internal/sys;
    there are still many functions left.
    
    The original version of this CL (patch set 1) called the new package
    "internal/sys", but for packages that needed both "internal/sys" and
    "cmd/internal/sys" the import of the former had to be done with a
    different name, which was confusing and also required a hack in
    cmd/dist.
    
    Updates #56006.
    
    Change-Id: I866d62e75adbf3a640a06e2c7386a6e9e2a18d91
    Reviewed-on: https://go-review.googlesource.com/c/go/+/438475
    
    
    Reviewed-by: default avatarBryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: default avatarCherry Mui <cherryyz@google.com>
    Run-TryBot: Than McIntosh <thanm@google.com>
    8bd803fd
    History
    cmd/internal/sys: migrate support.go functions to new internal pkg
    Than McIntosh authored
    Separate out the functions from cmd/internal/sys/support.go and
    migrate them to a new package internal/platform, so that functions such as
    "RaceDetectorSupported" can be called from tests in std as well as in
    cmd. This isn't a complete move of everything in cmd/internal/sys;
    there are still many functions left.
    
    The original version of this CL (patch set 1) called the new package
    "internal/sys", but for packages that needed both "internal/sys" and
    "cmd/internal/sys" the import of the former had to be done with a
    different name, which was confusing and also required a hack in
    cmd/dist.
    
    Updates #56006.
    
    Change-Id: I866d62e75adbf3a640a06e2c7386a6e9e2a18d91
    Reviewed-on: https://go-review.googlesource.com/c/go/+/438475
    
    
    Reviewed-by: default avatarBryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: default avatarCherry Mui <cherryyz@google.com>
    Run-TryBot: Than McIntosh <thanm@google.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.