Use config package to handle all controller configurations

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

config/config.go

@@ -6,14 +6,16 @@ import (
 
 	"github.com/google/uuid"
 	"github.com/sirupsen/logrus"
+	log "github.com/sirupsen/logrus"
 	"github.com/spf13/viper"
 )
 
 const (
-	defaultTimeOutDuration10minutes = "10m"
+	defaultTimeOutDuration10minutes = time.Minute * 10
 	basePNDUUIDKey                  = "basePNDUUID"
 	baseSouthBoundTypeKey           = "baseSouthBoundType"
 	baseSouthBoundUUIDKey           = "baseSouthBoundUUID"
+	changeTimeoutKey                = "GOSDN_CHANGE_TIMEOUT"
 )
 
 // BasePndUUID is an uuid for the base PND
@@ -89,18 +91,15 @@ func getUUIDFromViper(viperKey string) (uuid.UUID, error) {
 }
 
 func setChangeTimeout() error {
-	var err error
-	e := os.Getenv("GOSDN_CHANGE_TIMEOUT")
+	e := os.Getenv(changeTimeoutKey)
 	if e != "" {
-		ChangeTimeout, err = time.ParseDuration(e)
+		changeTimeout, err := time.ParseDuration(e)
 		if err != nil {
-			return err
+			log.Fatal(err)
 		}
+		ChangeTimeout = changeTimeout
 	} else {
-		ChangeTimeout, err = time.ParseDuration(defaultTimeOutDuration10minutes)
-		if err != nil {
-			return err
-		}
+		ChangeTimeout = time.Minute * 10
 	}
 
 	return nil