Skip to content
Snippets Groups Projects
Commit e018ae41 authored by Fabian Seidl's avatar Fabian Seidl
Browse files

some linter pleasing

parent fedc62e3
No related branches found
No related tags found
1 merge request!416Resolve "Refactor how PNDs are implemented in the code"
Pipeline #130386 failed
This commit is part of merge request !416. Comments created here will be created in the context of that merge request.
...@@ -184,11 +184,17 @@ func (n *NetworkElementServer) Update(ctx context.Context, request *mnepb.Update ...@@ -184,11 +184,17 @@ func (n *NetworkElementServer) Update(ctx context.Context, request *mnepb.Update
if err != nil { if err != nil {
return &mnepb.UpdateNetworkElementResponse{ return &mnepb.UpdateNetworkElementResponse{
Timestamp: time.Now().UnixNano(), Timestamp: time.Now().UnixNano(),
Status: mnepb.Status_STATUS_OK, Status: mnepb.Status_STATUS_ERROR,
}, err }, err
} }
err = n.ensureIntendedConfigurationIsAppliedOnNetworkElement(mneID) err = n.ensureIntendedConfigurationIsAppliedOnNetworkElement(mneID)
if err != nil {
return &mnepb.UpdateNetworkElementResponse{
Timestamp: time.Now().UnixNano(),
Status: mnepb.Status_STATUS_ERROR,
}, err
}
return &mnepb.UpdateNetworkElementResponse{ return &mnepb.UpdateNetworkElementResponse{
Timestamp: time.Now().UnixNano(), Timestamp: time.Now().UnixNano(),
......
...@@ -7,7 +7,6 @@ import ( ...@@ -7,7 +7,6 @@ import (
ppb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/pnd" ppb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/pnd"
spb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/southbound" spb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/southbound"
"code.fbi.h-da.de/danet/gosdn/controller/interfaces/networkdomain" "code.fbi.h-da.de/danet/gosdn/controller/interfaces/networkdomain"
"code.fbi.h-da.de/danet/gosdn/controller/interfaces/southbound"
"code.fbi.h-da.de/danet/gosdn/controller/metrics" "code.fbi.h-da.de/danet/gosdn/controller/metrics"
"code.fbi.h-da.de/danet/gosdn/controller/nucleus" "code.fbi.h-da.de/danet/gosdn/controller/nucleus"
"code.fbi.h-da.de/danet/gosdn/controller/store" "code.fbi.h-da.de/danet/gosdn/controller/store"
...@@ -22,7 +21,6 @@ import ( ...@@ -22,7 +21,6 @@ import (
type PndServer struct { type PndServer struct {
ppb.UnimplementedPndServiceServer ppb.UnimplementedPndServiceServer
pndService networkdomain.Service pndService networkdomain.Service
sbiService southbound.Service
} }
// NewPndServer receives a pndStore and returns a new pndServer. // NewPndServer receives a pndStore and returns a new pndServer.
......
...@@ -108,6 +108,7 @@ func NewPND( ...@@ -108,6 +108,7 @@ func NewPND(
return pnd, nil return pnd, nil
} }
// NewPNDEntity creates a PND object as it is stored in the storage.
func NewPNDEntity(pndID uuid.UUID, name string, description string) networkdomain.NetworkDomain { func NewPNDEntity(pndID uuid.UUID, name string, description string) networkdomain.NetworkDomain {
pnd := &pndImplementation{ pnd := &pndImplementation{
Id: pndID, Id: pndID,
......
...@@ -144,7 +144,7 @@ func (t *TopoService) GetAll() ([]links.Link, error) { ...@@ -144,7 +144,7 @@ func (t *TopoService) GetAll() ([]links.Link, error) {
return topo, nil return topo, nil
} }
// GetAll returns the current topology. // Get returns the current topology.
func (t *TopoService) Get(query query.Query) (links.Link, error) { func (t *TopoService) Get(query query.Query) (links.Link, error) {
link, err := t.store.Get(query) link, err := t.store.Get(query)
if err != nil { if err != nil {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment