Skip to content
Snippets Groups Projects
Commit 199a53f1 authored by Fabian Seidl's avatar Fabian Seidl
Browse files

fixed issue with nil sbiService when fetching schema

parent 542d6763
No related branches found
No related tags found
1 merge request!416Resolve "Refactor how PNDs are implemented in the code"
Pipeline #130747 failed
This commit is part of merge request !416. Comments created here will be created in the context of that merge request.
...@@ -38,10 +38,13 @@ func getTestAuthInterceptorServer(t *testing.T) (*AuthInterceptor, *UserServer, ...@@ -38,10 +38,13 @@ func getTestAuthInterceptorServer(t *testing.T) (*AuthInterceptor, *UserServer,
t.Fatal(err) t.Fatal(err)
} }
sbiStore := nucleus.NewSbiStore()
sbiService := nucleus.NewSbiService(sbiStore, eventService)
s := NewAuthInterceptor(jwtManager, userService, roleService) s := NewAuthInterceptor(jwtManager, userService, roleService)
u := NewUserServer(jwtManager, userService) u := NewUserServer(jwtManager, userService)
r := NewRoleServer(jwtManager, roleService) r := NewRoleServer(jwtManager, roleService)
sbiServer := NewSbiServer(pndService) sbiServer := NewSbiServer(sbiService)
if err := clearAndCreateAuthTestSetup(userService, roleService); err != nil { if err := clearAndCreateAuthTestSetup(userService, roleService); err != nil {
t.Fatal(err) t.Fatal(err)
......
...@@ -55,7 +55,7 @@ func NewNBI( ...@@ -55,7 +55,7 @@ func NewNBI(
Pnd: NewPndServer(pndService, sbiService), Pnd: NewPndServer(pndService, sbiService),
Core: NewCoreServer(pndService), Core: NewCoreServer(pndService),
Csbi: NewCsbiServer(pnds), Csbi: NewCsbiServer(pnds),
Sbi: NewSbiServer(pndService), Sbi: NewSbiServer(sbiService),
Auth: NewAuthServer(&jwt, users), Auth: NewAuthServer(&jwt, users),
User: NewUserServer(&jwt, users), User: NewUserServer(&jwt, users),
Role: NewRoleServer(&jwt, roles), Role: NewRoleServer(&jwt, roles),
......
...@@ -6,7 +6,7 @@ import ( ...@@ -6,7 +6,7 @@ import (
"io" "io"
spb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/southbound" spb "code.fbi.h-da.de/danet/gosdn/api/go/gosdn/southbound"
"code.fbi.h-da.de/danet/gosdn/controller/interfaces/networkdomain" "code.fbi.h-da.de/danet/gosdn/controller/interfaces/southbound"
"code.fbi.h-da.de/danet/gosdn/controller/metrics" "code.fbi.h-da.de/danet/gosdn/controller/metrics"
"code.fbi.h-da.de/danet/gosdn/controller/store" "code.fbi.h-da.de/danet/gosdn/controller/store"
"github.com/google/uuid" "github.com/google/uuid"
...@@ -27,13 +27,13 @@ const ( ...@@ -27,13 +27,13 @@ const (
// SbiServer represents a sbi server. // SbiServer represents a sbi server.
type SbiServer struct { type SbiServer struct {
spb.UnimplementedSbiServiceServer spb.UnimplementedSbiServiceServer
pndService networkdomain.Service sbiService southbound.Service
} }
// NewSbiServer receives a pndStore and returns a new sbiServer. // NewSbiServer receives a pndStore and returns a new sbiServer.
func NewSbiServer(pndService networkdomain.Service) *SbiServer { func NewSbiServer(sbiService southbound.Service) *SbiServer {
return &SbiServer{ return &SbiServer{
pndService: pndService, sbiService: sbiService,
} }
} }
...@@ -43,22 +43,12 @@ func (s SbiServer) GetSchema(request *spb.GetSchemaRequest, stream spb.SbiServic ...@@ -43,22 +43,12 @@ func (s SbiServer) GetSchema(request *spb.GetSchemaRequest, stream spb.SbiServic
start := metrics.StartHook(labels, grpcRequestsTotal) start := metrics.StartHook(labels, grpcRequestsTotal)
defer metrics.FinishHook(labels, start, grpcRequestDurationSecondsTotal, grpcRequestDurationSeconds) defer metrics.FinishHook(labels, start, grpcRequestDurationSecondsTotal, grpcRequestDurationSeconds)
pid, err := uuid.Parse(request.Pid)
if err != nil {
return handleRPCError(labels, err)
}
sid, err := uuid.Parse(request.Sid) sid, err := uuid.Parse(request.Sid)
if err != nil { if err != nil {
return handleRPCError(labels, err) return handleRPCError(labels, err)
} }
pnd, err := s.pndService.Get(store.Query{ID: pid}) sbi, err := s.sbiService.Get(store.Query{ID: sid})
if err != nil {
return handleRPCError(labels, err)
}
sbi, err := pnd.GetSBI(sid)
if err != nil { if err != nil {
return handleRPCError(labels, err) return handleRPCError(labels, err)
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment