Skip to content
Snippets Groups Projects
Commit 5c90f4f3 authored by André Sterba's avatar André Sterba Committed by Neil-Jocelyn Schark
Browse files

Resolve "Enable linter to catch unused fields and let them fail lint"

parent d96553ea
No related branches found
No related tags found
1 merge request!28Resolve "Enable linter to catch unused fields and let them fail lint"
Pipeline #270435 passed
...@@ -16,7 +16,7 @@ linters: ...@@ -16,7 +16,7 @@ linters:
- nestif - nestif
- paralleltest - paralleltest
- protogetter - protogetter
- testifylint - testifylint
- whitespace - whitespace
- durationcheck - durationcheck
- bodyclose - bodyclose
...@@ -28,6 +28,15 @@ linters: ...@@ -28,6 +28,15 @@ linters:
- sqlclosecheck - sqlclosecheck
#- exhaustruct # Does not work with gRPC, as it wants us to implement 'UnimplementedHealthCtrlServer', which is obviously not intended to be implemented. Would otherwise be useful. #- exhaustruct # Does not work with gRPC, as it wants us to implement 'UnimplementedHealthCtrlServer', which is obviously not intended to be implemented. Would otherwise be useful.
settings:
unused:
# Mark all function parameters as used.
parameters-are-used: false
# Mark all local variables as used.
local-variables-are-used: false
# Mark all identifiers inside generated files as used.
generated-is-used: false
formatters: formatters:
# Enable specific formatter. # Enable specific formatter.
# Default: [] (uses standard Go formatting) # Default: [] (uses standard Go formatting)
......
...@@ -19,7 +19,7 @@ import ( ...@@ -19,7 +19,7 @@ import (
// It is used to start the server and register services. // It is used to start the server and register services.
// It also implements the io.Closer interface to allow for graceful shutdown. // It also implements the io.Closer interface to allow for graceful shutdown.
type GRPCServer interface { type GRPCServer interface {
Start(serviceRegister func(server *grpc.Server, app *application.Application)) Start(func(server *grpc.Server, app *application.Application))
io.Closer io.Closer
} }
...@@ -35,7 +35,7 @@ func NewGrpcServer( ...@@ -35,7 +35,7 @@ func NewGrpcServer(
app *application.Application, app *application.Application,
logger *zap.SugaredLogger, logger *zap.SugaredLogger,
) (GRPCServer, error) { ) (GRPCServer, error) {
options, err := buildOptions(config, logger) options, err := buildOptions(logger)
if err != nil { if err != nil {
return nil, err return nil, err
} }
...@@ -71,7 +71,6 @@ func (g gRPCServer) Close() error { ...@@ -71,7 +71,6 @@ func (g gRPCServer) Close() error {
} }
func buildOptions( func buildOptions(
config config.Config,
logs *zap.SugaredLogger, logs *zap.SugaredLogger,
) ([]grpc.ServerOption, error) { ) ([]grpc.ServerOption, error) {
grpcPanicRecoveryHandler := func(p any) (err error) { grpcPanicRecoveryHandler := func(p any) (err error) {
......
...@@ -32,6 +32,8 @@ func (r *Routing) RequestRoute( ...@@ -32,6 +32,8 @@ func (r *Routing) RequestRoute(
// calculate route // calculate route
time.Sleep(time.Second) time.Sleep(time.Second)
r.logger.Debugf("got request route %+v", req)
return model.Route{ return model.Route{
ID: "1337", ID: "1337",
}, nil }, nil
...@@ -45,6 +47,7 @@ func (r *Routing) AnnouncePayloadRelay( ...@@ -45,6 +47,7 @@ func (r *Routing) AnnouncePayloadRelay(
defer span.End() defer span.End()
// gossip routes to KMS // gossip routes to KMS
r.logger.Debugf("got announce payload relay %+v", req)
return nil return nil
} }
...@@ -56,6 +59,8 @@ func (r *Routing) PayloadRelayFinished( ...@@ -56,6 +59,8 @@ func (r *Routing) PayloadRelayFinished(
_, span := r.tracer.Start(ctx, "payload-relay-finished") _, span := r.tracer.Start(ctx, "payload-relay-finished")
defer span.End() defer span.End()
r.logger.Debugf("got payload relay finished %+v", req)
return nil return nil
} }
...@@ -63,6 +68,8 @@ func (r *Routing) PayloadRelayError(ctx context.Context, req ports.PayloadRelayE ...@@ -63,6 +68,8 @@ func (r *Routing) PayloadRelayError(ctx context.Context, req ports.PayloadRelayE
_, span := r.tracer.Start(ctx, "payload-relay-error") _, span := r.tracer.Start(ctx, "payload-relay-error")
defer span.End() defer span.End()
r.logger.Debugf("got payload relay error %+v", req)
return nil return nil
} }
...@@ -73,5 +80,7 @@ func (r *Routing) PushKeyStoreFillLevel( ...@@ -73,5 +80,7 @@ func (r *Routing) PushKeyStoreFillLevel(
_, span := r.tracer.Start(ctx, "push-key-store-fill-level") _, span := r.tracer.Start(ctx, "push-key-store-fill-level")
defer span.End() defer span.End()
r.logger.Debugf("got push key store fill level %+v", req)
return nil return nil
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment