diff --git a/.golangci.yaml b/.golangci.yaml index 2ea353ebae7b7ff94c1eb73d60ff840be9ae083a..10a8202cfd77d773eede55489435d32ae9ec7076 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -16,7 +16,7 @@ linters: - nestif - paralleltest - protogetter - - testifylint + - testifylint - whitespace - durationcheck - bodyclose @@ -28,6 +28,15 @@ linters: - sqlclosecheck #- exhaustruct # Does not work with gRPC, as it wants us to implement 'UnimplementedHealthCtrlServer', which is obviously not intended to be implemented. Would otherwise be useful. + settings: + unused: + # Mark all function parameters as used. + parameters-are-used: false + # Mark all local variables as used. + local-variables-are-used: false + # Mark all identifiers inside generated files as used. + generated-is-used: false + formatters: # Enable specific formatter. # Default: [] (uses standard Go formatting) diff --git a/ctrl/internal/infrastructure/grpc/server.go b/ctrl/internal/infrastructure/grpc/server.go index 97539372e9b0361c0f2eea32a51af873af76dc28..10dd7b8a86bc4dcd7a17626fd4c35fffc718cbcc 100644 --- a/ctrl/internal/infrastructure/grpc/server.go +++ b/ctrl/internal/infrastructure/grpc/server.go @@ -19,7 +19,7 @@ import ( // It is used to start the server and register services. // It also implements the io.Closer interface to allow for graceful shutdown. type GRPCServer interface { - Start(serviceRegister func(server *grpc.Server, app *application.Application)) + Start(func(server *grpc.Server, app *application.Application)) io.Closer } @@ -35,7 +35,7 @@ func NewGrpcServer( app *application.Application, logger *zap.SugaredLogger, ) (GRPCServer, error) { - options, err := buildOptions(config, logger) + options, err := buildOptions(logger) if err != nil { return nil, err } @@ -71,7 +71,6 @@ func (g gRPCServer) Close() error { } func buildOptions( - config config.Config, logs *zap.SugaredLogger, ) ([]grpc.ServerOption, error) { grpcPanicRecoveryHandler := func(p any) (err error) { diff --git a/ctrl/internal/service/routing.go b/ctrl/internal/service/routing.go index 1ed3c8818aa94650ec8a80f7b843461f2922a591..c6217969b68a5fe0f70b9c1dc688e2b931363d6d 100644 --- a/ctrl/internal/service/routing.go +++ b/ctrl/internal/service/routing.go @@ -32,6 +32,8 @@ func (r *Routing) RequestRoute( // calculate route time.Sleep(time.Second) + r.logger.Debugf("got request route %+v", req) + return model.Route{ ID: "1337", }, nil @@ -45,6 +47,7 @@ func (r *Routing) AnnouncePayloadRelay( defer span.End() // gossip routes to KMS + r.logger.Debugf("got announce payload relay %+v", req) return nil } @@ -56,6 +59,8 @@ func (r *Routing) PayloadRelayFinished( _, span := r.tracer.Start(ctx, "payload-relay-finished") defer span.End() + r.logger.Debugf("got payload relay finished %+v", req) + return nil } @@ -63,6 +68,8 @@ func (r *Routing) PayloadRelayError(ctx context.Context, req ports.PayloadRelayE _, span := r.tracer.Start(ctx, "payload-relay-error") defer span.End() + r.logger.Debugf("got payload relay error %+v", req) + return nil } @@ -73,5 +80,7 @@ func (r *Routing) PushKeyStoreFillLevel( _, span := r.tracer.Start(ctx, "push-key-store-fill-level") defer span.End() + r.logger.Debugf("got push key store fill level %+v", req) + return nil }