Remove copies of mutex locks

net/ip_test.go

@@ -141,9 +141,9 @@ func TestIPFromProtoIP(t *testing.T) {
 		},
 	}
 
-	for _, test := range tests {
-		res := IPFromProtoIP(&test.proto)
-		assert.Equal(t, test.expected, res, test.name)
+	for i := range tests {
+		res := IPFromProtoIP(&tests[i].proto)
+		assert.Equal(t, tests[i].expected, res, tests[i].name)
 	}
 }
 

net/prefix_test.go

@@ -153,9 +153,9 @@ func TestNewPrefixFromProtoPrefix(t *testing.T) {
 		},
 	}
 
-	for _, test := range tests {
-		res := NewPrefixFromProtoPrefix(&test.proto)
-		assert.Equal(t, test.expected, *res, test.name)
+	for i := range tests {
+		res := NewPrefixFromProtoPrefix(&tests[i].proto)
+		assert.Equal(t, tests[i].expected, *res, tests[i].name)
 	}
 }
 

protocols/bgp/server/fsm_address_family_test.go

@@ -50,7 +50,7 @@ func TestFSMAFIInitDispose(t *testing.T) {
 
 	wg := sync.WaitGroup{}
 	wg.Add(1)
-	assert.Equal(t, wg, f.updateSender.wg)
+	assert.EqualValues(t, &wg, &f.updateSender.wg)
 
 	assert.Equal(t, uint64(1), f.adjRIBOut.ClientCount())