From 81a8ab7acf39ea5526450f22582449bc082283f3 Mon Sep 17 00:00:00 2001
From: Christoph Petrausch <christoph.petrausch@inovex.de>
Date: Wed, 15 Apr 2020 21:38:05 +0200
Subject: [PATCH] Remove copies of mutex locks
---
net/ip_test.go | 6 +++---
net/prefix_test.go | 6 +++---
protocols/bgp/server/fsm_address_family_test.go | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/ip_test.go b/net/ip_test.go
index f2b39a3a..28b3bbfb 100644
--- a/net/ip_test.go
+++ b/net/ip_test.go
@@ -141,9 +141,9 @@ func TestIPFromProtoIP(t *testing.T) {
},
}
- for _, test := range tests {
- res := IPFromProtoIP(&test.proto)
- assert.Equal(t, test.expected, res, test.name)
+ for i := range tests {
+ res := IPFromProtoIP(&tests[i].proto)
+ assert.Equal(t, tests[i].expected, res, tests[i].name)
}
}
diff --git a/net/prefix_test.go b/net/prefix_test.go
index 7c961ee4..3a72b024 100644
--- a/net/prefix_test.go
+++ b/net/prefix_test.go
@@ -153,9 +153,9 @@ func TestNewPrefixFromProtoPrefix(t *testing.T) {
},
}
- for _, test := range tests {
- res := NewPrefixFromProtoPrefix(&test.proto)
- assert.Equal(t, test.expected, *res, test.name)
+ for i := range tests {
+ res := NewPrefixFromProtoPrefix(&tests[i].proto)
+ assert.Equal(t, tests[i].expected, *res, tests[i].name)
}
}
diff --git a/protocols/bgp/server/fsm_address_family_test.go b/protocols/bgp/server/fsm_address_family_test.go
index ac6a0e07..45b9412a 100644
--- a/protocols/bgp/server/fsm_address_family_test.go
+++ b/protocols/bgp/server/fsm_address_family_test.go
@@ -50,7 +50,7 @@ func TestFSMAFIInitDispose(t *testing.T) {
wg := sync.WaitGroup{}
wg.Add(1)
- assert.Equal(t, wg, f.updateSender.wg)
+ assert.EqualValues(t, &wg, &f.updateSender.wg)
assert.Equal(t, uint64(1), f.adjRIBOut.ClientCount())
--
GitLab