Skip to content
Snippets Groups Projects
Commit e3fd4ba7 authored by Cherry Mui's avatar Cherry Mui Committed by Gopher Robot
Browse files

[release-branch.go1.22] cmd/link: generate Mach-O UUID when -B flag is specified

Currently, on Mach-O, the Go linker doesn't generate LC_UUID in
internal linking mode. This causes some macOS system tools unable
to track the binary, as well as in some cases the binary unable
to access local network on macOS 15.

This CL makes the linker start generate LC_UUID. Currently, the
UUID is generated if the -B flag is specified. And we'll make it
generate UUID by default in a later CL. The -B flag is currently
for generating GNU build ID on ELF, which is a similar concept to
Mach-O's UUID. Instead of introducing another flag, we just use
the same flag and the same setting. Specifically, "-B gobuildid"
will generate a UUID based on the Go build ID.

Updates #68678.
Fixes #69991.

Cq-Include-Trybots: luci.golang.try:go1.22-darwin-amd64_14,go1.22-darwin-arm64_13
Change-Id: I90089a78ba144110bf06c1c6836daf2d737ff10a
Reviewed-on: https://go-review.googlesource.com/c/go/+/618595


Reviewed-by: default avatarMichael Knyszek <mknyszek@google.com>
Reviewed-by: default avatarIngo Oeser <nightlyone@googlemail.com>
Reviewed-by: default avatarThan McIntosh <thanm@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 20ed6031)
Reviewed-on: https://go-review.googlesource.com/c/go/+/622596


Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: default avatarMichael Pratt <mpratt@google.com>
TryBot-Bypass: Michael Pratt <mpratt@google.com>
parent 29252e4c
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment