-
- Downloads
cmd/compile: switch to final unified IR export format
Now that there's a native go/types importer for unified IR, the compiler no longer needs to stay backwards compatible with old iexport importers. This CL also updates the go/types and go/internal/gcimporter tests to expect that the unified IR importer sets the receiver parameter type to the underlying Interface type, rather than the Named type. This is a temporary workaround until we make a decision on #49906. Notably, this makes `GOEXPERIMENT=unified go test` work on generics code without requiring `-vet=off` (because previously cmd/vet was relying on unified IR's backwards-compatible iexport data, which omitted generic types). Change-Id: Iac7a2346bb7a91e6690fb2978fb702fadae5559d Reviewed-on: https://go-review.googlesource.com/c/go/+/386004 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by:Robert Griesemer <gri@golang.org> Reviewed-by:
Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Showing
- src/cmd/compile/internal/importer/gcimporter_test.go 16 additions, 4 deletionssrc/cmd/compile/internal/importer/gcimporter_test.go
- src/cmd/compile/internal/noder/export.go 8 additions, 38 deletionssrc/cmd/compile/internal/noder/export.go
- src/cmd/compile/internal/noder/import.go 37 additions, 56 deletionssrc/cmd/compile/internal/noder/import.go
- src/cmd/compile/internal/noder/reader.go 0 additions, 10 deletionssrc/cmd/compile/internal/noder/reader.go
- src/cmd/compile/internal/noder/unified.go 2 additions, 14 deletionssrc/cmd/compile/internal/noder/unified.go
- src/go/internal/gcimporter/gcimporter_test.go 17 additions, 10 deletionssrc/go/internal/gcimporter/gcimporter_test.go
- src/go/types/eval_test.go 9 additions, 1 deletionsrc/go/types/eval_test.go
Loading
Please register or sign in to comment