-
- Downloads
[dev.regabi] cmd/compile: use Node getters and setters [generated]
Now that we have all the getters and setters defined, use them and unexport all the actual Node fields. This is the next step toward replacing Node with an interface. [git-generate] cd src/cmd/compile/internal/gc rf ' ex . ../ir ../ssa { import "cmd/compile/internal/ir" import "cmd/compile/internal/types" import "cmd/internal/src" var n, x *ir.Node var op ir.Op var t *types.Type var f *ir.Func var m *ir.Name var s *types.Sym var p src.XPos var i int64 var e uint16 var nodes ir.Nodes n.Op = op -> n.SetOp(op) n.Left = x -> n.SetLeft(x) n.Right = x -> n.SetRight(x) n.Orig = x -> n.SetOrig(x) n.Type = t -> n.SetType(t) n.Func = f -> n.SetFunc(f) n.Name = m -> n.SetName(m) n.Sym = s -> n.SetSym(s) n.Pos = p -> n.SetPos(p) n.Xoffset = i -> n.SetXoffset(i) n.Esc = e -> n.SetEsc(e) n.Ninit.Append -> n.PtrNinit().Append n.Ninit.AppendNodes -> n.PtrNinit().AppendNodes n.Ninit.MoveNodes -> n.PtrNinit().MoveNodes n.Ninit.Prepend -> n.PtrNinit().Prepend n.Ninit.Set -> n.PtrNinit().Set n.Ninit.Set1 -> n.PtrNinit().Set1 n.Ninit.Set2 -> n.PtrNinit().Set2 n.Ninit.Set3 -> n.PtrNinit().Set3 &n.Ninit -> n.PtrNinit() n.Ninit = nodes -> n.SetNinit(nodes) n.Nbody.Append -> n.PtrNbody().Append n.Nbody.AppendNodes -> n.PtrNbody().AppendNodes n.Nbody.MoveNodes -> n.PtrNbody().MoveNodes n.Nbody.Prepend -> n.PtrNbody().Prepend n.Nbody.Set -> n.PtrNbody().Set n.Nbody.Set1 -> n.PtrNbody().Set1 n.Nbody.Set2 -> n.PtrNbody().Set2 n.Nbody.Set3 -> n.PtrNbody().Set3 &n.Nbody -> n.PtrNbody() n.Nbody = nodes -> n.SetNbody(nodes) n.List.Append -> n.PtrList().Append n.List.AppendNodes -> n.PtrList().AppendNodes n.List.MoveNodes -> n.PtrList().MoveNodes n.List.Prepend -> n.PtrList().Prepend n.List.Set -> n.PtrList().Set n.List.Set1 -> n.PtrList().Set1 n.List.Set2 -> n.PtrList().Set2 n.List.Set3 -> n.PtrList().Set3 &n.List -> n.PtrList() n.List = nodes -> n.SetList(nodes) n.Rlist.Append -> n.PtrRlist().Append n.Rlist.AppendNodes -> n.PtrRlist().AppendNodes n.Rlist.MoveNodes -> n.PtrRlist().MoveNodes n.Rlist.Prepend -> n.PtrRlist().Prepend n.Rlist.Set -> n.PtrRlist().Set n.Rlist.Set1 -> n.PtrRlist().Set1 n.Rlist.Set2 -> n.PtrRlist().Set2 n.Rlist.Set3 -> n.PtrRlist().Set3 &n.Rlist -> n.PtrRlist() n.Rlist = nodes -> n.SetRlist(nodes) } ex . ../ir ../ssa { import "cmd/compile/internal/ir" var n *ir.Node n.Op -> n.GetOp() n.Left -> n.GetLeft() n.Right -> n.GetRight() n.Orig -> n.GetOrig() n.Type -> n.GetType() n.Func -> n.GetFunc() n.Name -> n.GetName() n.Sym -> n.GetSym() n.Pos -> n.GetPos() n.Xoffset -> n.GetXoffset() n.Esc -> n.GetEsc() avoid (*ir.Node).PtrNinit avoid (*ir.Node).PtrNbody avoid (*ir.Node).PtrList avoid (*ir.Node).PtrRlist n.Ninit -> n.GetNinit() n.Nbody -> n.GetNbody() n.List -> n.GetList() n.Rlist -> n.GetRlist() } ' cd ../ir rf ' mv Node.Op Node.op mv Node.GetOp Node.Op mv Node.Left Node.left mv Node.GetLeft Node.Left mv Node.Right Node.right mv Node.GetRight Node.Right mv Node.Orig Node.orig mv Node.GetOrig Node.Orig mv Node.Type Node.typ mv Node.GetType Node.Type mv Node.Func Node.fn mv Node.GetFunc Node.Func mv Node.Name Node.name mv Node.GetName Node.Name # All uses are in other Node methods already. mv Node.E Node.e mv Node.Sym Node.sym mv Node.GetSym Node.Sym mv Node.Pos Node.pos mv Node.GetPos Node.Pos mv Node.Esc Node.esc mv Node.GetEsc Node.Esc # While we are here, rename Xoffset to more idiomatic Offset. mv Node.Xoffset Node.offset mv Node.GetXoffset Node.Offset mv Node.SetXoffset Node.SetOffset # While we are here, rename Ninit, Nbody to more idiomatic Init, Body. mv Node.Ninit Node.init mv Node.GetNinit Node.Init mv Node.PtrNinit Node.PtrInit mv Node.SetNinit Node.SetInit mv Node.Nbody Node.body mv Node.GetNbody Node.Body mv Node.PtrNbody Node.PtrBody mv Node.SetNbody Node.SetBody mv Node.List Node.list mv Node.GetList Node.List mv Node.Rlist Node.rlist mv Node.GetRlist Node.Rlist # Unexport these mv Node.SetHasOpt Node.setHasOpt mv Node.SetHasVal Node.setHasVal ' Change-Id: I9894f633375c5237a29b6d6d7b89ba181b56ca3a Reviewed-on: https://go-review.googlesource.com/c/go/+/273009 Trust: Russ Cox <rsc@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:Matthew Dempsky <mdempsky@google.com>
Showing
- src/cmd/compile/internal/gc/alg.go 77 additions, 77 deletionssrc/cmd/compile/internal/gc/alg.go
- src/cmd/compile/internal/gc/align.go 6 additions, 6 deletionssrc/cmd/compile/internal/gc/align.go
- src/cmd/compile/internal/gc/bexport.go 2 additions, 2 deletionssrc/cmd/compile/internal/gc/bexport.go
- src/cmd/compile/internal/gc/bimport.go 1 addition, 1 deletionsrc/cmd/compile/internal/gc/bimport.go
- src/cmd/compile/internal/gc/closure.go 111 additions, 111 deletionssrc/cmd/compile/internal/gc/closure.go
- src/cmd/compile/internal/gc/const.go 86 additions, 86 deletionssrc/cmd/compile/internal/gc/const.go
- src/cmd/compile/internal/gc/dcl.go 133 additions, 133 deletionssrc/cmd/compile/internal/gc/dcl.go
- src/cmd/compile/internal/gc/dwinl.go 3 additions, 3 deletionssrc/cmd/compile/internal/gc/dwinl.go
- src/cmd/compile/internal/gc/embed.go 18 additions, 18 deletionssrc/cmd/compile/internal/gc/embed.go
- src/cmd/compile/internal/gc/escape.go 259 additions, 259 deletionssrc/cmd/compile/internal/gc/escape.go
- src/cmd/compile/internal/gc/export.go 27 additions, 27 deletionssrc/cmd/compile/internal/gc/export.go
- src/cmd/compile/internal/gc/gen.go 11 additions, 11 deletionssrc/cmd/compile/internal/gc/gen.go
- src/cmd/compile/internal/gc/gsubr.go 12 additions, 12 deletionssrc/cmd/compile/internal/gc/gsubr.go
- src/cmd/compile/internal/gc/iexport.go 169 additions, 169 deletionssrc/cmd/compile/internal/gc/iexport.go
- src/cmd/compile/internal/gc/iimport.go 72 additions, 72 deletionssrc/cmd/compile/internal/gc/iimport.go
- src/cmd/compile/internal/gc/init.go 10 additions, 10 deletionssrc/cmd/compile/internal/gc/init.go
- src/cmd/compile/internal/gc/initorder.go 36 additions, 34 deletionssrc/cmd/compile/internal/gc/initorder.go
- src/cmd/compile/internal/gc/inl.go 277 additions, 277 deletionssrc/cmd/compile/internal/gc/inl.go
- src/cmd/compile/internal/gc/main.go 20 additions, 20 deletionssrc/cmd/compile/internal/gc/main.go
- src/cmd/compile/internal/gc/noder.go 127 additions, 127 deletionssrc/cmd/compile/internal/gc/noder.go
Loading
Please register or sign in to comment