Skip to content
Snippets Groups Projects
Commit 96537d50 authored by Cherry Mui's avatar Cherry Mui Committed by Gopher Robot
Browse files

[release-branch.go1.23] cmd/link: choose one with larger size for duplicated BSS symbols

When two packages declare a variable with the same name (with
linkname at least on one side), the linker will choose one as the
actual definition of the symbol if one has content (i.e. a DATA
symbol) and the other does not (i.e. a BSS symbol). When both have
content, it is redefinition error. When neither has content,
currently the choice is sort of arbitrary (depending on symbol
loading order, etc. which are subject to change).

One use case for that is that one wants to reference a symbol
defined in another package, and the reference side just wants to
see some of the fields, so it may be declared with a smaller type.
In this case, we want to choose the one with the larger size as
the true definition. Otherwise the code accessing the larger
sized one may read/write out of bounds, corrupting the next
variable. This CL makes the linker do so.

Also include followup fix CL 661915.

Fixes #73091.
Updates #72032.

Change-Id: I160aa9e0234702066cb8f141c186eaa89d0fcfed
Reviewed-on: https://go-review.googlesource.com/c/go/+/660696


LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: default avatarDavid Chase <drchase@google.com>
Reviewed-by: default avatarThan McIntosh <thanm@golang.org>
(cherry picked from commit 8f6c083d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/662355
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
parent 7a2cfb70
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment