-
- Downloads
[release-branch.go1.22] cmd/compile: add 0-sized-value simplification to copyelim
The problem was caused by faulty handling of unSSA-able operations on zero-sized data in expand calls, but there is no point to operations on zero-sized data. This CL adds a simplify step to the first place in SSA where all values are processed and replaces anything producing a 0-sized struct/array with the corresponding Struct/Array Make0 operation (of the appropriate type). I attempted not generating them in ssagen, but that was a larger change, and also had bugs. This is simple and obvious. The only question is whether it would be worthwhile to do it earlier (in numberlines or phielem). Fixes #68594. Fixes #68585. Change-Id: I0a596b3d272798015e7bb6b1a20411241759fe0e Reviewed-on: https://go-review.googlesource.com/c/go/+/568258 Reviewed-by:Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by:
Keith Randall <khr@golang.org> Reviewed-by:
Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 6f5d7745) Reviewed-on: https://go-review.googlesource.com/c/go/+/601195
Loading
Please register or sign in to comment