-
- Downloads
all: fix most of the remaining windows -d=checkptr violations
This change replaces buf := [HUGE_CONST]*T)(unsafe.Pointer(p))[:] with buf := [HUGE_CONST]*T)(unsafe.Pointer(p))[:n:n] Pointer p points to n of T elements. New unsafe pointer conversion logic verifies that both first and last elements point into the same Go variable. This change replaces [:] with [:n:n] to please pointer checker. According to @mdempsky, compiler specially recognizes when you combine a pointer conversion with a full slice operation in a single expression and makes an exception. After this, only one failure in net remains when running: go test -a -short -gcflags=all=-d=checkptr std cmd Updates #34972 Change-Id: I2c8731650c856264bc788e4e07fa0530f7c250fa Reviewed-on: https://go-review.googlesource.com/c/go/+/208617 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
Showing
- src/go/build/deps_test.go 1 addition, 1 deletionsrc/go/build/deps_test.go
- src/internal/syscall/windows/reparse_windows.go 6 additions, 4 deletionssrc/internal/syscall/windows/reparse_windows.go
- src/internal/syscall/windows/syscall_windows.go 20 additions, 0 deletionssrc/internal/syscall/windows/syscall_windows.go
- src/net/interface_windows.go 1 addition, 1 deletionsrc/net/interface_windows.go
- src/net/lookup_windows.go 6 additions, 5 deletionssrc/net/lookup_windows.go
- src/os/env_windows.go 11 additions, 7 deletionssrc/os/env_windows.go
- src/os/exec_windows.go 2 additions, 3 deletionssrc/os/exec_windows.go
- src/os/os_windows_test.go 5 additions, 3 deletionssrc/os/os_windows_test.go
- src/os/user/lookup_windows.go 3 additions, 8 deletionssrc/os/user/lookup_windows.go
- src/syscall/security_windows.go 1 addition, 1 deletionsrc/syscall/security_windows.go
- src/syscall/syscall_windows.go 20 additions, 1 deletionsrc/syscall/syscall_windows.go
Loading
Please register or sign in to comment