Skip to content
Snippets Groups Projects
  • Roland Shoemaker's avatar
    9f39a43e
    crypto/tls: de-prioritize AES-GCM ciphers when lacking hardware support · 9f39a43e
    Roland Shoemaker authored
    When either the server or client are lacking hardware support for
    AES-GCM ciphers, indicated by the server lacking the relevant
    instructions and by the client not putting AES-GCM ciphers at the top
    of its preference list, reorder the preference list to de-prioritize
    AES-GCM based ciphers when they are adjacent to other AEAD ciphers.
    
    Also updates a number of recorded openssl TLS tests which previously
    only specified TLS 1.2 cipher preferences (using -cipher), but not
    TLS 1.3 cipher preferences (using -ciphersuites), to specify both
    preferences, making these tests more predictable.
    
    Fixes #41181.
    
    Change-Id: Ied896c96c095481e755aaff9ff0746fb4cb9568e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/262857
    
    
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: default avatarFilippo Valsorda <filippo@golang.org>
    Trust: Roland Shoemaker <roland@golang.org>
    Trust: Katie Hockman <katie@golang.org>
    9f39a43e
    History
    crypto/tls: de-prioritize AES-GCM ciphers when lacking hardware support
    Roland Shoemaker authored
    When either the server or client are lacking hardware support for
    AES-GCM ciphers, indicated by the server lacking the relevant
    instructions and by the client not putting AES-GCM ciphers at the top
    of its preference list, reorder the preference list to de-prioritize
    AES-GCM based ciphers when they are adjacent to other AEAD ciphers.
    
    Also updates a number of recorded openssl TLS tests which previously
    only specified TLS 1.2 cipher preferences (using -cipher), but not
    TLS 1.3 cipher preferences (using -ciphersuites), to specify both
    preferences, making these tests more predictable.
    
    Fixes #41181.
    
    Change-Id: Ied896c96c095481e755aaff9ff0746fb4cb9568e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/262857
    
    
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: default avatarFilippo Valsorda <filippo@golang.org>
    Trust: Roland Shoemaker <roland@golang.org>
    Trust: Katie Hockman <katie@golang.org>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.