Skip to content
Snippets Groups Projects
  • Bryan C. Mills's avatar
    cacac8bd
    cmd/dist: do not unset GOROOT_FINAL prior to running tests · cacac8bd
    Bryan C. Mills authored
    Also do not unset it by default in the tests for cmd/go.
    
    GOROOT_FINAL affects the GOROOT value embedded in binaries,
    such as 'cmd/cgo'. If its value changes and a build command
    is performed that depends on one of those binaries, the binary
    would be spuriously rebuilt.
    
    Instead, only unset it in the specific tests that make assumptions
    about the GOROOT paths embedded in specific compiled binaries.
    That may cause those tests to do a little extra rebuilding when
    GOROOT_FINAL is set, but that little bit of extra rebuilding
    seems preferable to spuriously-stale binaries.
    
    Fixes #39385
    
    Change-Id: I7c87b1519bb5bcff64babf1505fd1033ffa4f4fb
    Reviewed-on: https://go-review.googlesource.com/c/go/+/236819
    
    
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarDmitri Shuralyov <dmitshur@golang.org>
    cacac8bd
    History
    cmd/dist: do not unset GOROOT_FINAL prior to running tests
    Bryan C. Mills authored
    Also do not unset it by default in the tests for cmd/go.
    
    GOROOT_FINAL affects the GOROOT value embedded in binaries,
    such as 'cmd/cgo'. If its value changes and a build command
    is performed that depends on one of those binaries, the binary
    would be spuriously rebuilt.
    
    Instead, only unset it in the specific tests that make assumptions
    about the GOROOT paths embedded in specific compiled binaries.
    That may cause those tests to do a little extra rebuilding when
    GOROOT_FINAL is set, but that little bit of extra rebuilding
    seems preferable to spuriously-stale binaries.
    
    Fixes #39385
    
    Change-Id: I7c87b1519bb5bcff64babf1505fd1033ffa4f4fb
    Reviewed-on: https://go-review.googlesource.com/c/go/+/236819
    
    
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarDmitri Shuralyov <dmitshur@golang.org>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.