Skip to content
Snippets Groups Projects
  • Matthew Dempsky's avatar
    feec53c4
    [dev.typeparams] cmd/compile: skip types2 GC test during bootstrapping · feec53c4
    Matthew Dempsky authored
    Unified includes a check to make sure that types2 memory has been
    garbage collected, but it relies on precise finalization, which we
    provide (for dynamically allocated objects, at least) but isn't
    guaranteed by the Go spec. In particular, Go 1.4 doesn't provide this.
    
    The check is strictly unnecessary and only exists to make sure we
    don't regress and start holding onto types2 memory accidentally. So
    just disable the check during bootstrap builds.
    
    Change-Id: Ie54fe53b2edba02c0b0b1e5ae39d81be8a0ace8d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/329269
    
    
    Trust: Matthew Dempsky <mdempsky@google.com>
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
    feec53c4
    History
    [dev.typeparams] cmd/compile: skip types2 GC test during bootstrapping
    Matthew Dempsky authored
    Unified includes a check to make sure that types2 memory has been
    garbage collected, but it relies on precise finalization, which we
    provide (for dynamically allocated objects, at least) but isn't
    guaranteed by the Go spec. In particular, Go 1.4 doesn't provide this.
    
    The check is strictly unnecessary and only exists to make sure we
    don't regress and start holding onto types2 memory accidentally. So
    just disable the check during bootstrap builds.
    
    Change-Id: Ie54fe53b2edba02c0b0b1e5ae39d81be8a0ace8d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/329269
    
    
    Trust: Matthew Dempsky <mdempsky@google.com>
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.