Skip to content
Snippets Groups Projects
  • Matthew Dempsky's avatar
    f0b15635
    cmd/compile/internal/types: remove unneeded functionality · f0b15635
    Matthew Dempsky authored
    This CL removes a handful of features that were only needed for the
    pre-unified frontends.
    
    In particular, Type.Pkg was a hack for iexport so that
    go/types.Var.Pkg could be precisely populated for struct fields and
    signature parameters by gcimporter, but it's no longer necessary with
    the unified export data format because we now write export data
    directly from types2-supplied type descriptors.
    
    Several other features (e.g., OrigType, implicit interfaces, type
    parameters on signatures) are no longer relevant to the unified
    frontend, because it only uses types1 to represent instantiated
    generic types.
    
    Updates #57410.
    
    Change-Id: I84fd1da5e0b65d2ab91d244a7bb593821ee916e7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/458622
    
    
    Reviewed-by: default avatarKeith Randall <khr@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: default avatarKeith Randall <khr@golang.org>
    f0b15635
    History
    cmd/compile/internal/types: remove unneeded functionality
    Matthew Dempsky authored
    This CL removes a handful of features that were only needed for the
    pre-unified frontends.
    
    In particular, Type.Pkg was a hack for iexport so that
    go/types.Var.Pkg could be precisely populated for struct fields and
    signature parameters by gcimporter, but it's no longer necessary with
    the unified export data format because we now write export data
    directly from types2-supplied type descriptors.
    
    Several other features (e.g., OrigType, implicit interfaces, type
    parameters on signatures) are no longer relevant to the unified
    frontend, because it only uses types1 to represent instantiated
    generic types.
    
    Updates #57410.
    
    Change-Id: I84fd1da5e0b65d2ab91d244a7bb593821ee916e7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/458622
    
    
    Reviewed-by: default avatarKeith Randall <khr@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: default avatarKeith Randall <khr@golang.org>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.