Skip to content
Snippets Groups Projects
  • Cherry Mui's avatar
    630ef2ed
    cmd/link: remove allocation in decoding type name · 630ef2ed
    Cherry Mui authored
    The type name symbol is always from a Go object file and we never
    change it. Convert the data to string using unsafe conversion
    without allocation.
    
    Linking cmd/go (on macOS/amd64),
    
    name           old alloc/op   new alloc/op   delta
    Deadcode_GC      1.25MB ± 0%    1.17MB ± 0%   -6.29%  (p=0.000 n=20+20)
    
    name           old allocs/op  new allocs/op  delta
    Deadcode_GC       8.98k ± 0%     0.10k ± 3%  -98.91%  (p=0.000 n=20+20)
    
    Change-Id: I33117ad1f991e4f14ce0b38cceec50b041e3c0a4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/490915
    
    
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    Reviewed-by: default avatarThan McIntosh <thanm@google.com>
    630ef2ed
    History
    cmd/link: remove allocation in decoding type name
    Cherry Mui authored
    The type name symbol is always from a Go object file and we never
    change it. Convert the data to string using unsafe conversion
    without allocation.
    
    Linking cmd/go (on macOS/amd64),
    
    name           old alloc/op   new alloc/op   delta
    Deadcode_GC      1.25MB ± 0%    1.17MB ± 0%   -6.29%  (p=0.000 n=20+20)
    
    name           old allocs/op  new allocs/op  delta
    Deadcode_GC       8.98k ± 0%     0.10k ± 3%  -98.91%  (p=0.000 n=20+20)
    
    Change-Id: I33117ad1f991e4f14ce0b38cceec50b041e3c0a4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/490915
    
    
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    Reviewed-by: default avatarThan McIntosh <thanm@google.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.