src/database/sql/sql.go · 083ef5462494e81ee23316245c5d65085a3f62d9 · Martin Stiemerling / Go

3 years ago

database/sql: prevent closes slices from assigning to free conn · 48f1cde9

Pavel authored 3 years ago

In function connectionCleanerRunLocked append to closing slice affects db.freeConns and vise versa. Sometimes valid connections are closed and some invalid not.

Change-Id: I5282f15be3e549533b7d994b17b2060db3c0e7da
GitHub-Last-Rev: b3eb3ab6f49c036519f777fc7189e9507010c166
GitHub-Pull-Request: golang/go#49429
Reviewed-on: https://go-review.googlesource.com/c/go/+/362214

Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

48f1cde9

History

database/sql: prevent closes slices from assigning to free conn

Pavel authored 3 years ago

In function connectionCleanerRunLocked append to closing slice affects db.freeConns and vise versa. Sometimes valid connections are closed and some invalid not.

Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

Code owners

Assign users and groups as approvers for specific file changes. Learn more.