src/crypto/cipher/gcm_test.go · 067f28ad73e096a7ca1e892ba89280dfa4fa419d · Martin Stiemerling / Go

You need to sign in or sign up before continuing.

1 year ago

Revert "crypto/internal/boring: use noescape and nocallback cgo directives" · 067f28ad

This reverts CL 525035.

Reason for revert: breaks many Google-internal tests (#63739), suspected miscompilation

Change-Id: I8cbebca0a187d12e16c405b2373c754e4a397ef4
Reviewed-on: https://go-review.googlesource.com/c/go/+/537598


Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>

067f28ad

History

Revert "crypto/internal/boring: use noescape and nocallback cgo directives"

Michael Stapelberg authored 1 year ago

This reverts CL 525035.

Reason for revert: breaks many Google-internal tests (#63739), suspected miscompilation

Change-Id: I8cbebca0a187d12e16c405b2373c754e4a397ef4
Reviewed-on: https://go-review.googlesource.com/c/go/+/537598


Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>

Code owners

Assign users and groups as approvers for specific file changes. Learn more.