Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
dex
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
hdacloud
dex
Commits
bf39130b
Commit
bf39130b
authored
6 years ago
by
Taras Burko
Browse files
Options
Downloads
Patches
Plain Diff
Configurable team name field for GitHub connector
parent
bb75dcd7
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Documentation/connectors/github.md
+9
-0
9 additions, 0 deletions
Documentation/connectors/github.md
connector/github/github.go
+24
-9
24 additions, 9 deletions
connector/github/github.go
with
33 additions
and
9 deletions
Documentation/connectors/github.md
+
9
−
0
View file @
bf39130b
...
...
@@ -28,6 +28,7 @@ connectors:
clientID
:
$GITHUB_CLIENT_ID
clientSecret
:
$GITHUB_CLIENT_SECRET
redirectURI
:
http://127.0.0.1:5556/dex/callback
# Optional organizations and teams, communicated through the "groups" scope.
#
# NOTE: This is an EXPERIMENTAL config option and will likely change.
...
...
@@ -51,6 +52,14 @@ connectors:
teams
:
-
red-team
-
blue-team
# Optional choice between 'name' (default) or 'slug'.
#
# As an example, group claims for member of 'Site Reliability Engineers' in
# Acme organization would yield:
# - ['acme:Site Reliability Engineers'] for 'name'
# - ['acme:site-reliability-engineers'] for 'slug'
teamNameField
:
slug
```
## GitHub Enterprise
...
...
This diff is collapsed.
Click to expand it.
connector/github/github.go
+
24
−
9
View file @
bf39130b
...
...
@@ -40,13 +40,14 @@ var reLast = regexp.MustCompile("<([^>]+)>; rel=\"last\"")
// Config holds configuration options for github logins.
type
Config
struct
{
ClientID
string
`json:"clientID"`
ClientSecret
string
`json:"clientSecret"`
RedirectURI
string
`json:"redirectURI"`
Org
string
`json:"org"`
Orgs
[]
Org
`json:"orgs"`
HostName
string
`json:"hostName"`
RootCA
string
`json:"rootCA"`
ClientID
string
`json:"clientID"`
ClientSecret
string
`json:"clientSecret"`
RedirectURI
string
`json:"redirectURI"`
Org
string
`json:"org"`
Orgs
[]
Org
`json:"orgs"`
HostName
string
`json:"hostName"`
RootCA
string
`json:"rootCA"`
TeamNameField
string
`json:"teamNameField"`
}
// Org holds org-team filters, in which teams are optional.
...
...
@@ -107,6 +108,13 @@ func (c *Config) Open(id string, logger logrus.FieldLogger) (connector.Connector
}
switch
c
.
TeamNameField
{
case
"name"
,
"slug"
,
""
:
g
.
teamNameField
=
c
.
TeamNameField
default
:
return
nil
,
fmt
.
Errorf
(
"invalid connector config: unsupported team name field value `%s`"
,
c
.
TeamNameField
)
}
return
&
g
,
nil
}
...
...
@@ -134,7 +142,8 @@ type githubConnector struct {
// Used to support untrusted/self-signed CA certs.
rootCA
string
// HTTP Client that trusts the custom delcared rootCA cert.
httpClient
*
http
.
Client
httpClient
*
http
.
Client
teamNameField
string
}
// groupsRequired returns whether dex requires GitHub's 'read:org' scope. Dex
...
...
@@ -566,6 +575,7 @@ type team struct {
Org
struct
{
Login
string
`json:"login"`
}
`json:"organization"`
Slug
string
`json:"slug"`
}
// teamsForOrg queries the GitHub API for team membership within a specific organization.
...
...
@@ -586,7 +596,12 @@ func (c *githubConnector) teamsForOrg(ctx context.Context, client *http.Client,
for
_
,
team
:=
range
teams
{
if
team
.
Org
.
Login
==
orgName
{
groups
=
append
(
groups
,
team
.
Name
)
switch
c
.
teamNameField
{
case
"name"
,
""
:
groups
=
append
(
groups
,
team
.
Name
)
case
"slug"
:
groups
=
append
(
groups
,
team
.
Slug
)
}
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment