Skip to content
Snippets Groups Projects
Unverified Commit a0cf8b2d authored by MM53's avatar MM53 Committed by GitHub
Browse files

fix: Do not evaluate skipApproval on approval page (#3086) 


Signed-off-by: default avatarMM53 <28218664+MM53@users.noreply.github.com>
parent 79d5874b
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 0 additions and 6 deletions
server/handlers.go
+ 0
− 6
View file @ a0cf8b2d
...@@ -628,12 +628,6 @@ func (s *Server) handleApproval(w http.ResponseWriter, r *http.Request) { ...@@ -628,12 +628,6 @@ func (s *Server) handleApproval(w http.ResponseWriter, r *http.Request) {
switch r.Method { switch r.Method {
case http.MethodGet: case http.MethodGet:
// TODO: `finalizeLogin()` now sends code directly to client without going through this endpoint,
// the `if skipApproval { ... }` block needs to be removed after a grace period.
if s.skipApproval {
s.sendCodeResponse(w, r, authReq)
return
}
client, err := s.storage.GetClient(authReq.ClientID) client, err := s.storage.GetClient(authReq.ClientID)
if err != nil { if err != nil {
s.logger.Errorf("Failed to get client %q: %v", authReq.ClientID, err) s.logger.Errorf("Failed to get client %q: %v", authReq.ClientID, err)
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment