Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
dex
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
hdacloud
dex
Commits
774242f7
Commit
774242f7
authored
8 years ago
by
Eric Chiang
Browse files
Options
Downloads
Patches
Plain Diff
Documentation/proposals: added a caveats section to upstream refreshing proposal
parent
1e5133a9
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
Documentation/proposals/upstream-refreshing.md
+18
-3
18 additions, 3 deletions
Documentation/proposals/upstream-refreshing.md
with
18 additions
and
3 deletions
Documentation/proposals/upstream-refreshing.md
+
18
−
3
View file @
774242f7
...
...
@@ -2,12 +2,12 @@
## TL;DR
Today, if a user deletes their G
oogle
account, dex will keep allowing clients to
Today, if a user deletes their G
itHub
account, dex will keep allowing clients to
refresh tokens on that user's behalf because dex never checks back in with
G
oogle
.
G
itHub
.
This is a proposal to change the connector package so the dex can check back
in with G
oogle
.
in with G
itHub
.
## The problem
...
...
@@ -148,3 +148,18 @@ func (db passwordDB) Refresh(s connector.Scopes, identity connector.Identity) (c
return
identity
,
nil
}
```
## Caveats
Certain providers, such as Google, will only grant a single refresh token for each
client + end user pair. The second time one's requested, no refresh token is
returned. This means refresh tokens must be stored by dex as objects on an
upstream identity rather than part of a downstream refresh even.
Right now
`ConnectorData`
is too general for this since it is only stored with a
refresh token and can't be shared between sessions. This should be rethought in
combination with the
[
`user-object.md`
](
./user-object.md
)
proposal to see if
there are reasonable ways for us to do this.
This isn't a problem for providers like GitHub because they return the same
refresh token every time. We don't need to track a token per client.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment