Skip to content
Snippets Groups Projects
Unverified Commit 3705207f authored by Maksim Nabokikh's avatar Maksim Nabokikh Committed by GitHub
Browse files

Do not escape password for LDAP connectors (#3470)

With the change introduced in https://github.com/dexidp/dex/pull/3372

 Dex declines passwords that contain special characters. Since password is not passed to any kind of filters, it is safe to pass a password as is. No LDAP query injections are possible.

This commit is a revert of password escaping.

Signed-off-by: default avatarm.nabokikh <maksim.nabokikh@flant.com>
parent 98980cad
No related branches found
No related tags found
No related merge requests found
...@@ -473,7 +473,6 @@ func (c *ldapConnector) Login(ctx context.Context, s connector.Scopes, username, ...@@ -473,7 +473,6 @@ func (c *ldapConnector) Login(ctx context.Context, s connector.Scopes, username,
) )
username = ldap.EscapeFilter(username) username = ldap.EscapeFilter(username)
password = ldap.EscapeFilter(password)
err = c.do(ctx, func(conn *ldap.Conn) error { err = c.do(ctx, func(conn *ldap.Conn) error {
entry, found, err := c.userEntry(conn, username) entry, found, err := c.userEntry(conn, username)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment